Closed
Bug 1383817
Opened 7 years ago
Closed 7 years ago
Clamp gamma and contrast for ScaledFontDWrite when creating Skia typeface instead of when setting up ClearType params
Categories
(Core :: Graphics: Text, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: lsalzman, Assigned: lsalzman)
References
(Depends on 1 open bug)
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
|
2.49 KB,
patch
|
mchang
:
review+
|
Details | Diff | Splinter Review |
Only clamping when we set up ClearType params leaves the possibility that default params can still have invalid values, which can trigger assertions like in bug 1348584 comment 20. It's better to clamp things when we're creating the Skia typeface, that way Skia always only ever gets valid values.
Attachment #8889513 -
Flags: review?(mchang)
|
||
Updated•7 years ago
|
Attachment #8889513 -
Flags: review?(mchang) → review+
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/02a519055f6f
clamp gamma/contrast for ScaledFontDWrite when creating SkTypeface. r=mchang
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•