1383848 - Pocket dropdown no longer works after bug 1355922 (blank popup)

Status: VERIFIED FIXED

(Firefox :: Pocket, defect)

Description

[Mike Kaply [:mkaply]]

After the checkin for bug 1355922, the pocket dropdown no longer works. It shows up blank.

It appears that libraryButton is null for this line in Pocket.jsm:

   onPanelViewShowing(event) {
     let document = event.target.ownerDocument;
     let window = document.defaultView;
     let iframe = window.pktUI.getPanelFrame();
 
+    let libraryButton = document.getElementById("library-button");
+    BrowserUtils.setToolbarButtonHeightProperty(libraryButton);

I can't link to dxr or searchfox since this code isn't showing up there.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1383848 - Null check library button since it's not there by default.

Review commit: https://reviewboard.mozilla.org/r/160576/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/160576/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8889560 [details]
Bug 1383848 - Null check library button since it's not there by default.

https://reviewboard.mozilla.org/r/160576/#review165858

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0521321d61a
Null check library button since it's not there by default. r=jaws

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b0521321d61a

Comment 10

[Saheda Reza [:Antora]]

I have reproduced the bug on Nightly according to (2017-07-24)

Fixing bug is verified on Latest Nightly -- 
Build ID   :20170727100347
User Agent :Mozilla/5.0 (Windows NT 6.1; rv:56.0) Gecko/20100101 Firefox/56.0

Tested OS-- Windows7 32bit

Comment 12

[Madhuri]

[bugday-20170801] 

status-ff56.0a1 : VERIFIED & FIXED.

Managed to reproduce the issue on Firefox Nightly under Windows 10 X 64.

The issue is no more reproducible on Firefox latest Nightly [BuildID : 20170801100311 , 56.0a1 (2017-08-01) (32-bit)]

Comment 13

[Madhuri]

(In reply to Madhuri from comment #12)
> [bugday-20170801] 
> 
> status-ff56.0a1 : VERIFIED & FIXED.
> 
> Managed to reproduce the issue on Firefox Nightly under Windows 10 X 64.
> 
> The issue is no more reproducible on Firefox latest Nightly [BuildID :
> 20170801100311 , 56.0a1 (2017-08-01) (32-bit)]

[bugday-20170802]  // due to updates on etherpad link.