Closed Bug 1383849 Opened 3 years ago Closed 3 years ago

Remove unused prop type `showGridOutline`

Categories

(DevTools :: Inspector, enhancement, P3)

enhancement

Tracking

(firefox56 fixed)

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: gl, Assigned: gl)

Details

Attachments

(1 file)

Warning: Failed prop type: Required prop `showGridOutline` was not specified in `App`.
    in App (created by Connect(App))
    in Connect(App)
    in Provider
    in div (created by Tabs)
    in div (created by Tabs)
    in div (created by Tabs)
    in Tabs (created by Tabbar)
    in div (created by Tabbar)
    in Tabbar
Attached patch 1383849.patchSplinter Review
Attachment #8889552 - Flags: review?(tigleym)
Comment on attachment 8889552 [details] [diff] [review]
1383849.patch

Review of attachment 8889552 [details] [diff] [review]:
-----------------------------------------------------------------

Verified the React propType error disappears with patch.
Attachment #8889552 - Flags: review?(tigleym)
Attachment #8889552 - Flags: review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d804536ac55
Remove unused prop type 'showGridOutline'. r=micah
https://hg.mozilla.org/mozilla-central/rev/6d804536ac55
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.