Closed
Bug 1383865
Opened 8 years ago
Closed 8 years ago
Document our usage of Sentry
Categories
(Firefox for iOS :: General, enhancement)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
fxios | 8.1+ | --- |
People
(Reporter: st3fan, Assigned: st3fan)
Details
(Whiteboard: [MobileCore][Sentry])
Document our usage of Sentry in Firefox for iOS.
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(ellee)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → sarentz
Assignee | ||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•8 years ago
|
Whiteboard: [MobileCore][Sentry] → [MobileCore][Sentry][needsuplift]
Comment 1•8 years ago
|
||
Hi Stefan,
I defer to Ben/Chenxia as data stewards for what needs to be included in our documentation. Ben mentioned at our previous meeting that we should at least link/cross-reference to the Sentry documentation, and I know that in other instances including a sample payload is helpful.
Flags: needinfo?(liuche)
Flags: needinfo?(ellee)
Flags: needinfo?(benjamin)
Comment 3•8 years ago
|
||
The documentation that I'm looking at is on the iOS github ( https://github.com/mozilla-mobile/firefox-ios/wiki/Crash-Reporting-with-Sentry ) and I'm going by the criteria on the Data Collection wiki ( https://wiki.mozilla.org/Firefox/Data_Collection ).
Data review:
This data is opt-out data for Release populations, and it's used to improve product stability. Reviewing the documentation, Sentry is open source and hosted by Mozilla, and the three types of data being sent are Device Information (Type 1), Application Information (Type 1, Sentry-only identifier), and Crash Information.
In Crash Information section:
* Exception message: I'm assuming this can *only* either be an iOS descriptive message, or empty. Can you make that explicit (if that's the case) because right now it says "sometimes" and "other times"? I would also reference Apple's policy against including PII in its reports (which would include this message from iOS). Assuming no chance of PII here, this is also Type 1 data.
* Images: this is libraries and frameworks included with Firefox iOS, which is also Type 1.
* Stack trace: this is functions in the code that led to this crash, so I'd say Type 1 or maybe Type 2. Optionally, might mention here that we don't dump any memory contents just to be explicit.
Finally, the only thing missing would be the person taking responsibility for the correctness of the data, which I assume here is Stefan.
Data review+ from me, since all the data collected here is Type 1 or Type 2, if you can make the one small change I mentioned in the "Exception message" section.
Flags: needinfo?(liuche)
Assignee | ||
Comment 4•8 years ago
|
||
- the first "Sentry" link links back to the wiki page itself, is that intentional?
- Nit: I'd move the “server is hosted and maintained by Mozilla” to be the second paragraph under High Level Summary - I think it’s a useful big-picture piece of information about the usage of Sentry
Updated•8 years ago
|
Whiteboard: [MobileCore][Sentry][needsuplift] → [MobileCore][Sentry]
Comment 5•8 years ago
|
||
Closing as requested by Stefan in triage.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•