Closed Bug 1383886 Opened 3 years ago Closed 3 years ago

Remove redundant element.closest() call in pocketPanelDidHide@browser/extensions/pocket/content/main.js

Categories

(Firefox :: General, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 56
Iteration:
56.3 - Jul 24
Tracking Status
firefox56 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

Details

(Whiteboard: [reserve-photon-animation])

Attachments

(1 file)

Right now we do:
> if (!libraryButton.closest("toolbar") ||
>     libraryButton.closest("toolbar").id != "nav-bar") {

But this can just be replaced by:
> if (libraryButton.closest("#nav-bar")) {
edit,
replaced with:
> if (!libraryButton.closest("#nav-bar")) {
Iteration: --- → 56.3 - Jul 24
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [reserve-photon-animation]
Comment on attachment 8889591 [details]
Bug 1383886 - Remove redundant element.closest() call since one call to closest() can do the work that was previously done by two calls to closest() and a property check.

https://reviewboard.mozilla.org/r/160614/#review165954

D'oh. How didn't I spot this in review. :-\
Attachment #8889591 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a08e0db2d20a
Remove redundant element.closest() call since one call to closest() can do the work that was previously done by two calls to closest() and a property check. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/a08e0db2d20a
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Flags: qe-verify? → qe-verify-
You need to log in before you can comment on or make changes to this bug.