1383904 - In Mac, authentication/elevation/ window does not appear when non-admin user tries to update the browser

Status: VERIFIED FIXED

(Toolkit :: Application Update, defect)

Comment 1

[Abe - QA (:Abe_LV)]

Steps to Reproduce:
1. Install a Firefox 55.0b1 as admin user
2. Switch to non-admin (standard) user and run the installed Firefox build installed in step 1.
3. Go to about:config and change following prefs:
app.update.badgeWaitTime to 10
app.update.lastUpdateTime.background-update-timer to 1
app.update.promptWaitTime to 30
app.update.timerMinimumDelay to 10
4. Exit Firefox
5.Launch same Firefox build with same profile 
6.Hamburger menu badge and then door-hanger appear
7.Click "Restart and Restore" in the doorhanger ui
8.Verify authentication window appears.


Actual Result:
authentication window does not appear

Expected Result:
Authentication window should appear

Additional note:
When "Restart and Restore" is clicked, browser restarts without updates.

Comment 2

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1383904 - Show old elevation dialog on elevation fail

The patch which originally disabled this seems to have been in
error, thinking it was the cause of failing tests on try. Can't
provide much more context than that.

Review commit: https://reviewboard.mozilla.org/r/160678/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/160678/

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 8889649 [details]
Bug 1383904 - Show old elevation dialog on elevation fail

https://reviewboard.mozilla.org/r/160678/#review165956

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/899590a34d56
Show old elevation dialog on elevation fail r=rstrong a=kwierso

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/899590a34d56

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8889649 [details]
Bug 1383904 - Show old elevation dialog on elevation fail

RStrong mentioned that we need this fix also uplifted to beta55 in order to fix bug 1382706. A+

Comment 7

[Robert Strong (they/them - no direct email)]

[Tracking Requested - why for this release]:
This fixes a regression on OS X that slipped through due to it using a very non-typical code path. The reason it doesn't have tests is in part due to that this requires the use of OS X authentication services which we can't have automated tests for similar to UAC on Windows.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Robert landed this.
https://hg.mozilla.org/releases/mozilla-beta/rev/009589ce9026e61b96633c6d7fe346159be3b21e

Comment 9

[Abe - QA (:Abe_LV)]

Verified as fixed in Nightly builds. Now, the elevation UI is displayed, and the update is applied.
But it still needs to be verified on Beta as well. Leaving the bug as it is until the beta build is ready for testing.

Comment 10

[Robert Strong (they/them - no direct email)]

Changing to verified 56 per comment #9

Comment 11

[Andrei Vaida [:avaida]]

Abe, since you're already familiar with this issue, could you please verify it on 55b13 as well?

Comment 12

[Abe - QA (:Abe_LV)]

It an update bug. This can not be verified on 55b13 as the patch was not landed on 55b12. 55b13 has the fix but to verify this we need to see the current build (55b13) updating. I think this is the last beta build in 55.
It is verified on Nightly (comment 9) but still, it has to be verified on beta as well.

Comment 13

[Abe - QA (:Abe_LV)]

It will be verified when the RC build comes out by early next week.

Comment 14

[Robert Strong (they/them - no direct email)]

I can create an update xml and provide steps to update 55b13 to 55b13 so this can be verified on beta. Just give me an hour or so.

Comment 15

[Abe - QA (:Abe_LV)]

I do not think we need to verify this bug like that. We need to verify it like what a normal user does.

Comment 16

[Robert Strong (they/them - no direct email)]

I'm fine with that though it would be just as valid as far as the client and what actually needs to be tested as using different update channels.

Comment 17

[Abe - QA (:Abe_LV)]

Verified as fixed.
The issue is fixed in beta build as well.