Closed Bug 1383926 Opened 3 years ago Closed 3 years ago

Stop defining Task.jsm lazy getter in browser.js and nsBrowserGlue.js

Categories

(Firefox :: General, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: marco, Assigned: marco)

Details

(Keywords: addon-compat, dev-doc-needed)

Attachments

(1 file)

It looks like Task.jsm is unused there, so we shouldn't need to define a lazy getter for it.
Attached patch PatchSplinter Review
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #8889656 - Flags: review?(mconley)
Comment on attachment 8889656 [details] [diff] [review]
Patch

Review of attachment 8889656 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Probably a good idea to do a try build to help ensure there aren't any sneaky Task.spawn's lying around in imported code (I did a quick sweep and I couldn't find any).
Attachment #8889656 - Flags: review?(mconley) → review+
Done: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a1a21f083ac1f7c826b09133fdfd3f6e9ebbebe.
There are some oranges, but I think they are unrelated.
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/865e18f01ece
Stop defining lazy module getter for Task.jsm in browser.js and nsBrowserGlue.js. r=mconley
The only concern here would be add-on browser overlays assuming they can use Task without importing the module. I'd have just waited next week to land, but since this is already on inbound, I'm just adding the addon-compat keyword. It's a trivial fix for add-on code anyways.
https://hg.mozilla.org/mozilla-central/rev/865e18f01ece
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.