Closed
Bug 1383984
Opened 7 years ago
Closed 7 years ago
Enable HTMLMediaElement debugging APIs from "tabs"-privileged extensions
Categories
(Core :: Audio/Video: Playback, enhancement)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: mozbugz, Assigned: mozbugz)
References
Details
Attachments
(1 file)
Adding the "debugger" privilege may not be so trivial (see bug 1381767), so in the meantime I would like to enable HTMLMediaElement debugging APIs from extensions with the "tabs" API. Reasons for using "tabs": - It's quite powerful and can inject scripts, so adding mild debugging-info request APIs does not overstep bounds in a scary way. - Both the "tabs" privilege, and the APIs, are already used by the Media Panel DevTools, so this change will make this extension Just Work. If/when "debugger" is introduced, we can easily remove this change while keeping the extension working.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8889724 [details] Bug 1383984 - Enable debugging HTMLMediaElement APIs with 'tabs' permission - https://reviewboard.mozilla.org/r/160794/#review166104
Attachment #8889724 -
Flags: review?(jyavenard) → review+
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8889724 [details] Bug 1383984 - Enable debugging HTMLMediaElement APIs with 'tabs' permission - https://reviewboard.mozilla.org/r/160794/#review166106 you need a DOM peer to review those changes...
Assignee | ||
Updated•7 years ago
|
Attachment #8889724 -
Flags: review?(bugs)
Assignee | ||
Comment 4•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8889724 [details] Bug 1383984 - Enable debugging HTMLMediaElement APIs with 'tabs' permission - https://reviewboard.mozilla.org/r/160794/#review166106 Thank you Jean-Yves. Olli, you reviewed bug 1339961, would you mind having a look at this follow-up? This is just changing the name of the enabling test in the webidl, to show the extra WebExtension permission that can enable these Mozilla-specific APIs.
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8889724 [details] Bug 1383984 - Enable debugging HTMLMediaElement APIs with 'tabs' permission - https://reviewboard.mozilla.org/r/160794/#review166148
Attachment #8889724 -
Flags: review?(bugs) → review+
Pushed by gsquelart@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/67aad6b837d4 Enable debugging HTMLMediaElement APIs with 'tabs' permission - r=jya,smaug
Assignee | ||
Comment 7•7 years ago
|
||
Thank you Olli. NI:myself to revisit, as Olli pointed out that maybe we should have properly-spec'd extension APIs instead.
Flags: needinfo?(gsquelart)
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/67aad6b837d4
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Assignee | ||
Updated•4 years ago
|
Flags: needinfo?(gsquelart)
You need to log in
before you can comment on or make changes to this bug.
Description
•