Enable HTMLMediaElement debugging APIs from "tabs"-privileged extensions

RESOLVED FIXED in Firefox 56

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: gerald, Assigned: gerald, NeedInfo)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

6 months ago
Adding the "debugger" privilege may not be so trivial (see bug 1381767), so in the meantime I would like to enable HTMLMediaElement debugging APIs from extensions with the "tabs" API.

Reasons for using "tabs":
- It's quite powerful and can inject scripts, so adding mild debugging-info request APIs does not overstep bounds in a scary way.
- Both the "tabs" privilege, and the APIs, are already used by the Media Panel DevTools, so this change will make this extension Just Work.

If/when "debugger" is introduced, we can easily remove this change while keeping the extension working.
Comment hidden (mozreview-request)

Comment 2

6 months ago
mozreview-review
Comment on attachment 8889724 [details]
Bug 1383984 - Enable debugging HTMLMediaElement APIs with 'tabs' permission -

https://reviewboard.mozilla.org/r/160794/#review166104
Attachment #8889724 - Flags: review?(jyavenard) → review+

Comment 3

6 months ago
mozreview-review
Comment on attachment 8889724 [details]
Bug 1383984 - Enable debugging HTMLMediaElement APIs with 'tabs' permission -

https://reviewboard.mozilla.org/r/160794/#review166106

you need a DOM peer to review those changes...
(Assignee)

Updated

6 months ago
Attachment #8889724 - Flags: review?(bugs)
(Assignee)

Comment 4

6 months ago
mozreview-review-reply
Comment on attachment 8889724 [details]
Bug 1383984 - Enable debugging HTMLMediaElement APIs with 'tabs' permission -

https://reviewboard.mozilla.org/r/160794/#review166106

Thank you Jean-Yves.

Olli, you reviewed bug 1339961, would you mind having a look at this follow-up?
This is just changing the name of the enabling test in the webidl, to show the extra WebExtension permission that can enable these Mozilla-specific APIs.

Comment 5

6 months ago
mozreview-review
Comment on attachment 8889724 [details]
Bug 1383984 - Enable debugging HTMLMediaElement APIs with 'tabs' permission -

https://reviewboard.mozilla.org/r/160794/#review166148
Attachment #8889724 - Flags: review?(bugs) → review+

Comment 6

6 months ago
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/67aad6b837d4
Enable debugging HTMLMediaElement APIs with 'tabs' permission - r=jya,smaug
(Assignee)

Comment 7

6 months ago
Thank you Olli.

NI:myself to revisit, as Olli pointed out that maybe we should have properly-spec'd extension APIs instead.
Flags: needinfo?(gsquelart)

Comment 8

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/67aad6b837d4
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.