1383984 - Enable HTMLMediaElement debugging APIs from "tabs"-privileged extensions

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Adding the "debugger" privilege may not be so trivial (see bug 1381767), so in the meantime I would like to enable HTMLMediaElement debugging APIs from extensions with the "tabs" API.

Reasons for using "tabs":
- It's quite powerful and can inject scripts, so adding mild debugging-info request APIs does not overstep bounds in a scary way.
- Both the "tabs" privilege, and the APIs, are already used by the Media Panel DevTools, so this change will make this extension Just Work.

If/when "debugger" is introduced, we can easily remove this change while keeping the extension working.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1383984 - Enable debugging HTMLMediaElement APIs with 'tabs' permission -

While "debugger" is not available yet, we can enable these debugging APIs for
extensions that have the "tabs" privilege, which includes the Media Panel
Devtools extension, so we/webdev will get better media-playback information.

Review commit: https://reviewboard.mozilla.org/r/160794/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/160794/

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8889724 [details]
Bug 1383984 - Enable debugging HTMLMediaElement APIs with 'tabs' permission -

https://reviewboard.mozilla.org/r/160794/#review166104

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8889724 [details]
Bug 1383984 - Enable debugging HTMLMediaElement APIs with 'tabs' permission -

https://reviewboard.mozilla.org/r/160794/#review166106

you need a DOM peer to review those changes...

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8889724 [details]
Bug 1383984 - Enable debugging HTMLMediaElement APIs with 'tabs' permission -

https://reviewboard.mozilla.org/r/160794/#review166106

Thank you Jean-Yves.

Olli, you reviewed bug 1339961, would you mind having a look at this follow-up?
This is just changing the name of the enabling test in the webidl, to show the extra WebExtension permission that can enable these Mozilla-specific APIs.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8889724 [details]
Bug 1383984 - Enable debugging HTMLMediaElement APIs with 'tabs' permission -

https://reviewboard.mozilla.org/r/160794/#review166148

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67aad6b837d4
Enable debugging HTMLMediaElement APIs with 'tabs' permission - r=jya,smaug

Comment 7

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Thank you Olli.

NI:myself to revisit, as Olli pointed out that maybe we should have properly-spec'd extension APIs instead.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/67aad6b837d4