Enable overrides to be targeted to either desktop or mobile

RESOLVED FIXED

Status

Web Compatibility Tools
Go Faster
RESOLVED FIXED
10 months ago
4 months ago

People

(Reporter: denschub, Assigned: denschub)

Tracking

(Blocks: 1 bug)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 months ago
We need a way for overrides to target either mobile or desktop if we want the GoFaster addon running in both environments - running Fennec overrides on Desktop is not a good idea.
(Assignee)

Comment 1

10 months ago
Created attachment 8889796 [details] [review]
Pull request - "Add a plattform filter for overrides"

Eric, as discussed on IRC, here is a pull request for you to look at. Also, as discussed, this includes two changes at once, but these are dependent on each others.

The first commit actually is part of bug 1338586 (as stated in the commit message, which oddly look very similar). Here, I adjust the `install.rdf` to allow the addon to actually be installed on Fennec. I also wrote a jake job that exports the extension files to `mobile/android/extensions/webcompat`. I doubt you need to roll your own Fennec build to test the changes, but if you want to, I can walk you through.

The second commit extends our user agent override object by the `applications` property. This allows us to have user agent overrides running on either Firefox Desktop, Firefox for Android, or both. I hope the documentation on that as well as the code is understandable without me explaining everything else, but feel free to ping me.
Attachment #8889796 - Flags: review?(etsai)
(Assignee)

Updated

10 months ago
Blocks: 1386807
Are we really still waiting on review here? What's the status Dennis?
Flags: needinfo?(dschubert)
(I suppose I could ask Eric as well...)
It's an old review request, I think it's not blocked by me. Remove the request for now. Add me anytime if need me.
Attachment #8889796 - Flags: review?(etsai) → review?
(Assignee)

Comment 5

6 months ago
Yes, Eric is right. I should have removed the r?, but stuff happened outside of Bugzilla. Will re-r? as soon as possible, and I can guarantee it will happen this week!

Sorry for the confusion, and sorry for keeping this r? flag in your queue, Eric!
Flags: needinfo?(dschubert)
(Assignee)

Comment 6

4 months ago
Created attachment 8949754 [details] [review]
Pull Request #20

This has been implemented in this PR, with r+ from :twisniewski.
Attachment #8889796 - Attachment is obsolete: true
Attachment #8889796 - Flags: review?
Attachment #8949754 - Flags: review+
(Assignee)

Updated

4 months ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.