1383995 - Run eslint fix over calendar.

Status: RESOLVED DUPLICATE of bug 1346797

(Calendar :: General, enhancement)

Comment 1

[Tom Prince [:tomprince]]

Attachment: Bug 1383995 - Run eslint fix over calendar.

Review commit: https://reviewboard.mozilla.org/r/160818/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/160818/

Comment 2

[[:MakeMyDay]]

Comment on attachment 8889739 [details]
Bug 1383995 - Run eslint fix over calendar.

Thanks for taking the effort to run the linter. However, the indentation rule is applied too stricktly in numerous cases. We use a little more relaxed rule here, the way the indentation is reduced for several files e.g.

calendar/base/content/calendar-task-tree.js or
calendar/base/content/calendar-ui-utils.js

is not wanted. Maybe the rule definition needs to be applied to respect that, especially if the linter will be easier to run in future. I didn't look at each change, but also some of the test code reformattings seem to be not wanted.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8889739 [details]
Bug 1383995 - Run eslint fix over calendar.

https://reviewboard.mozilla.org/r/160818/#review168122

I'm going to take MakeMyDay's comment as r-, I would have probably mentioned similar things. I'm going to clean up and land bug 1346797 now which should fix a few issues. I am surprised eslint is complaining so much about indent, I suspect that toolkit changed some of their rules which we inherit from.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Taking care in bug 1346797