Closed Bug 1384028 Opened 7 years ago Closed 3 years ago

Search suggestions prompt displayed again when restarting Fennec

Categories

(Firefox for Android Graveyard :: General, defect, P5)

55 Branch
ARM
Android
defect

Tracking

(fennec+, firefox55 affected, firefox58 affected, firefox59 affected)

RESOLVED INCOMPLETE
Tracking Status
fennec + ---
firefox55 --- affected
firefox58 --- affected
firefox59 --- affected

People

(Reporter: sflorean, Unassigned)

Details

Environment: 
Device: Huawei MediaPad M2 (Android 5.1.1), LG G4(Android 5.1);
Build: 55.0b12;

Steps to reproduce:
1. Launch Fennec and open 2-3 pages;
2. Tap on URL Bar and type anything to bring search suggestions;
3. Tap on "Yes" and choose one of the suggested sites;
4. Close Fennec;
5. Open Fennec and type anything on URL Bar.

Expected result:
After "Yes" button is tapped suggestions are displayed for the default search engine.

Actual result:
Just after the first char is typed, the Search Suggestion opt-in prompt is displayed:
"Would you like to turn on search suggestions? [No] [Yes]".

Notes:
- check the video: https://drive.google.com/open?id=0B0Rtl9OVJNMCMGR1dTFHaGpGOGc
Hi Jing Wei
Could you help check if it's a regression?
Thanks!
tracking-fennec: ? → +
Flags: needinfo?(topwu.tw)
I cannot reproduce this issue but after glancing the logic in 'BrowserSearch' I found that:

1. The 'suggestion prompt' is visible by default;
2. It would be shown/hidden when receiving "SearchEngines:Data" from Gecko thread.

So if the message is missed or delayed after the view inflation, the prompt would not be hidden.
Assignee: nobody → topwu.tw
Flags: needinfo?(topwu.tw)
Reproducible also when performing the steps:
1. Launch Fennec;
2. Go to Search and enable Show search suggestions;
3. Perform 2,3 searching;  
4. Go again to Search and disable Show search suggestions;
5. Search for cnn in URL bar.

Results: The Search Suggestion opt-in prompt is displayed again. 
Expected: The prompt is not displayed, because "search suggestions" was already disabled in settings. And this is the behavior if the user tap on "no" from prompt.
Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.
Priority: P3 → P5
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.