Closed Bug 1384040 Opened 5 years ago Closed 5 years ago

Stop using preprocessor in nsUrlClassifierLib.js and nsUrlClassifierListManager.js

Categories

(Toolkit :: General, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(1 file)

It looks like we are using the preprocessor only to include some files ("./content/moz/lang.js", "./content/request-backoff.js" for the first, "./content/listmanager.js" for the second), but they are only included in those files.
Can we directly include those files as content instead of keeping them as separate files?
Flags: needinfo?(francois)
Sounds good to me. Then we can kill that old "content" directory.
Flags: needinfo?(francois)
Attached patch PatchSplinter Review
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #8890121 - Flags: review?(francois)
Comment on attachment 8890121 [details] [diff] [review]
Patch

Review of attachment 8890121 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Make sure you put this on Try, including the firefox-ui tests (firefox-ui-functional-remote,firefox-ui-functional-remote-e10s) before landing.
Attachment #8890121 - Flags: review?(francois) → review+
The try build looks green enough, with some unrelated oranges: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8f767780fb0c942d49c1cda5706417ec1fbe77a4.
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5955de904e6a
Stop using preprocessor in nsUrlClassifierLib.js and nsUrlClassifierListManager.js, by directly copying the contents of the files they were including. r=francois
https://hg.mozilla.org/mozilla-central/rev/5955de904e6a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
No longer blocks: 1540875
You need to log in before you can comment on or make changes to this bug.