Closed Bug 1384044 Opened 7 years ago Closed 7 years ago

Stop using preprocessor in osfile.jsm

Categories

(Toolkit Graveyard :: OS.File, enhancement)

enhancement
Not set
normal

Tracking

(firefox56 fixed)

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(1 file)

This is one of the most recurring preprocessed file in code coverage output. If we could stop using the preprocessor, it would speed up the LCOV rewriting.
Attached patch PatchSplinter Review
Is this acceptable? It looks green on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=63eb9ece2c18c1ca74c4e95f7d2d5268956cd7a0.
Attachment #8889884 - Flags: review?(dteller)
Comment on attachment 8889884 [details] [diff] [review]
Patch

Review of attachment 8889884 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #8889884 - Flags: review?(dteller) → review+
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a53dcc2ca0aa
Stop using preprocessor in osfile.jsm. r=Yoric
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/a53dcc2ca0aa
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.