Closed Bug 1384045 Opened 7 years ago Closed 7 years ago

Show different contents in sync tour of onboarding for signed-in user.

Categories

(Firefox :: New Tab Page, enhancement, P3)

56 Branch
enhancement

Tracking

()

VERIFIED FIXED
Firefox 56
Tracking Status
firefox56 --- verified
firefox58 --- verified

People

(Reporter: rexboy, Assigned: rexboy)

References

(Blocks 1 open bug)

Details

(Whiteboard: [photon-onboarding])

Attachments

(2 files)

See the spec from bug 1378772 comment 17:
https://bug1378772.bmoattachments.org/attachment.cgi?id=8888952

(In reply to Verdi [:verdi] from comment #17)
> Here's what I'd like to do:
> 
> * If the user gets to the sync section of the tour and IS NOT SIGNED IN, we
> should mark the tour complete upon viewing the panel. Then if they create an
> account (whether or not they verify their account) we replace the tour panel
> with the attached version.
> 
> * If the user is ALREADY SIGNED IN before they view the sync panel it should
> already be marked as complete and we should only show them this new version
> of the panel.
> 
> Here is the approved copy for the panel:
> Headline: You’re signed in to Sync!
> Body: Sync works when you’re signed in to Firefox on more than one device.
> Have a mobile device? Install the Firefox app and sign in to get your
> bookmarks, history, and passwords on the go.
> 
> I'm not sure how we've included app store badges in other web pages but
> Apple and Google pages about them are here:
> https://developer.apple.com/app-store/marketing/guidelines/
> #downloadOnAppstore
> https://play.google.com/intl/en_us/badges/

Because we don't have conclusion on shipping store badges yet, so the discussion will keep going in bug 1378772, and this bug should focus on implementing everything remaining in the spec.
Assignee: nobody → rexboy
Status: NEW → ASSIGNED
Comment on attachment 8891262 [details]
Bug 1384045 - Show different contents in sync tour of onboarding for signed-in user.

https://reviewboard.mozilla.org/r/162470/#review167700

::: browser/extensions/onboarding/locales/en-US/onboarding.properties:77
(Diff revision 1)
>  
>  onboarding.tour-sync2=Sync
>  onboarding.tour-sync.title2=Pick up where you left off.
>  onboarding.tour-sync.description2=Sync makes it easy to access bookmarks, passwords, and even open tabs on all your devices. Sync also gives you control of the types of information you want, and don’t want, to share.
> +onboarding.tour-sync.logged-in.title=You’re signed in to Sync!
> +onboarding.tour-sync.logged-in.description=Sync works when you’re signed in to Firefox on more than one device. Have a mobile device? Install the Firefox app and sign in to get your bookmarks, history, and passwords on the go.

Usual issue: Firefox
Comment on attachment 8891262 [details]
Bug 1384045 - Show different contents in sync tour of onboarding for signed-in user.

https://reviewboard.mozilla.org/r/162470/#review167702

::: browser/extensions/onboarding/content/onboarding.css:238
(Diff revision 1)
>    float: none;
>  }
>  
> +#onboarding-tour-sync-page[data-login-state=logged-in] .show-on-logged-out,
> +#onboarding-tour-sync-page[data-login-state=logged-out] .show-on-logged-in {
> +  display: none;

can merge these 2 rule in 

```
#onboarding-overlay-dialog,
.onboarding-hidden {
  display: none;
}
```
Comment on attachment 8891262 [details]
Bug 1384045 - Show different contents in sync tour of onboarding for signed-in user.

https://reviewboard.mozilla.org/r/162470/#review167700

> Usual issue: Firefox

My bad. Thanks! They're fixed now.
Comment on attachment 8891262 [details]
Bug 1384045 - Show different contents in sync tour of onboarding for signed-in user.

https://reviewboard.mozilla.org/r/162470/#review167716
Attachment #8891262 - Flags: review?(francesco.lodolo) → review+
Attached image Scenario demo
Attaching a demo for what this patch intends to do.

Upon clicking the tour link, it asks the browser whether we're logged in, and determine if we show a "logged-in" version or "not logged-in" version of the sync tour.
Comment on attachment 8891262 [details]
Bug 1384045 - Show different contents in sync tour of onboarding for signed-in user.

https://reviewboard.mozilla.org/r/162470/#review167860
Attachment #8891262 - Flags: review?(dtownsend) → review+
Thank you Mossop!
Running try server before checking-in.
Blocks: 1385170
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c8e26d0c9d9a
Show different contents in sync tour of onboarding for signed-in user.r=flod,mossop
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c8e26d0c9d9a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
I have verified that the Sync tour responds differently to a signed in user on Win 10 x64, Win 7 x32, Ubuntu 16.04 x32, and Mac 10.12 with Firefox 58.
Flags: qe-verify+
QA Contact: jwilliams
You need to log in before you can comment on or make changes to this bug.