1384063 - Handle content crashes better in wpt

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement)

Description

[James Graham [:jgraham]]

Currently content crashes result in timeouts with no stack trace. That's not fast and not easy to debug. We need to at least produce a stack for these cases so they can be investigated easily.

Comment 1

[James Graham [:jgraham]]

Attachment: Bug 1384063 - Improve crash detection in wpt with e10s enabled,

Set MOZ_CRASHREPORTER_SHUTDOWN so that the browser terminates
immediately in the case of a content crash. This causes an early
return from executeAsyncScript, which also happens in cases with an
unhandled alert dialog, so check  if the connection is still alive to
distinguish between a crash and an error.

Review commit: https://reviewboard.mozilla.org/r/160938/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/160938/

Comment 2

[James Graham [:jgraham]]

Attachment: Bug 1384063 - Update wpt metadata for wpt crash changes,

Review commit: https://reviewboard.mozilla.org/r/160940/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/160940/

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 8889860 [details]
Bug 1384063 - Improve crash detection in wpt with e10s enabled,

https://reviewboard.mozilla.org/r/160938/#review166294

::: testing/web-platform/tests/tools/wptrunner/wptrunner/executors/executormarionette.py:380
(Diff revision 1)
>          else:
>              wait_timeout = None
>  
>          flag = self.result_flag.wait(wait_timeout)
> -        if self.result[1] is None:
> +
> +        if self.result is (None, None):

I don't think this test actually works--you can't test tuples for identity like that:
```
>>> (None, None) is (None, None)
False
```

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 8889861 [details]
Bug 1384063 - Update wpt metadata for wpt crash changes,

https://reviewboard.mozilla.org/r/160940/#review166328

I'm not sure I'm actually a useful reviewer for this, but I trust that you know what you're doing.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a114907759ec
Improve crash detection in wpt with e10s enabled, r=ted

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a114907759ec