Closed
Bug 1384137
Opened 7 years ago
Closed 7 years ago
Switch ffsetup to use mozprofile
Categories
(Testing :: Talos, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: tarek, Assigned: tarek)
References
Details
Attachments
(1 file)
Currently, Talos uses Marionette to install webextensions in the profile during a warmup start. see https://dxr.mozilla.org/mozilla-central/source/testing/talos/talos/ffsetup.py#117 We should use mozprofiler to perform this task instead. We could not use it before because mozprofile's AddonManager was unable to handle, but tha's being added in bug 1377510
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → tarek
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
This is a first patch for your comments. I am not sure how to verify it works in all cases though. e.g. is it just ts_paint_webext and tp5o_webext ?
Flags: needinfo?(jmaher)
Comment 3•7 years ago
|
||
best thing here is to run on try |./mach try -b o -p linux64 -u none -t all|
Flags: needinfo?(jmaher)
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8890811 [details] Bug 1384137 - use mozprofile instead of marionette to install webextensions https://reviewboard.mozilla.org/r/162026/#review167340 close, lets also remove marionette from the requirements.txt file: https://dxr.mozilla.org/mozilla-central/source/testing/talos/requirements.txt#10 outside of that this looks good
Attachment #8890811 -
Flags: review?(jmaher) → review-
Comment hidden (mozreview-request) |
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8890811 [details] Bug 1384137 - use mozprofile instead of marionette to install webextensions https://reviewboard.mozilla.org/r/162026/#review167790 Thanks looks good to me! I'm not familiar with Talos though, so rwood mind taking a quick glance at this as well? ::: testing/talos/talos/ffsetup.py:112 (Diff revision 2) > - extensions = [self.test_config.get('webextensions', None)] > - for ext in extensions: > + if isinstance(webextensions, str): > + webextensions = [self.test_config.get('webextensions', None)] nit: basestring instead of str nit: webextensions = [webextensions]
Attachment #8890811 -
Flags: review?(ahalberstadt) → review+
Updated•7 years ago
|
Flags: needinfo?(rwood)
Assignee | ||
Comment 8•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8890811 [details] Bug 1384137 - use mozprofile instead of marionette to install webextensions https://reviewboard.mozilla.org/r/162026/#review167790 thanks for the review, I will add rwood
Comment hidden (mozreview-request) |
Assignee | ||
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8890811 [details] Bug 1384137 - use mozprofile instead of marionette to install webextensions https://reviewboard.mozilla.org/r/162026/#review168224
Attachment #8890811 -
Flags: review+
Comment hidden (mozreview-request) |
Comment 12•7 years ago
|
||
Pushed by tziade@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/807acedaf25d use mozprofile instead of marionette to install webextensions r=ahal
Assignee | ||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment 13•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/807acedaf25d
You need to log in
before you can comment on or make changes to this bug.
Description
•