1384139 - Enforce PEP8 usage for Python files across the code base

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, enhancement, P3)

Description

[[DEACTIVATED] Adrian Gaudebert]

We have decided to enforce usage of the PEP8 Python style guide across our code base. We will go with lines of 100 characters for now (and can revisit later on if need be).

This work includes: 

* using a linter (pylama? )
* figuring out what PEP8 rules we want to ignore
* configuring the linter to ignore stuff like migration files
* update our documentation to explain what style guide we use
* fixing all issues across the code base

That last one we might want to split up into small chunks, to make the process smoother. For example, we could do apps one by one, started with the more stable ones. We want to make it as painless as possible for people already doing code changes that might conflict with this.

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

Attachment: Link to Github pull-request

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/19984460dad55ccf65813009b80e0941a0041bcf
Bug 1384139 - PEP8! PEP8 everywhere!  (#653)

* Bug 1384139 - Added PEP8 to pylama linting.

* Bug 1384139 - Fixed a bunch of PEP8 issues using autopep8.

* Fix bug 1384531 - Add a contributing guide to the docs.
Includes style guides and general tips on how to write code for Pontoon. Mostly inspired by the one from Socorro!

* Fix commit writing conventions.

* Ignore some common PEP8 errors for now and fix the rest.

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/e1ad1c2cb2b732f056756dcb4312e25e8a7e02ab
Bug 1384139 - Fix many PEP8 errors (#666)

* Bug 1384139 - Fix PEP8 errors in administration app.

* Bug 1384139 - Fix PEP8 errors in db app.

* Bug 1384139 - Fix PEP8 errors in localizations app.

* Bug 1384139 - Fix PEP8 errors in projects app.

* Bug 1384139 - Fix PEP8 errors in sync app.

* Bug 1384139 - Fix PEP8 errors in contributors app.

* Bug 1384139 - Fix PEP8 errors in machinery app.

* Bug 1384139 - Fix PEP8 errors in settings app.

* Bug 1384139 - Fix PEP8 errors in teams app.

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/725

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/5332b240c9f86f9aebfd09d63f771a494fc6b888
Fixes bug 1384139 - Fix all remaining PEP8 violations in Pontoon. (#725)

* Fixes bug 1384139 - Fix all remaining PEP8 violations in Pontoon.

* Run pylama only on the pontoon module.