Closed
Bug 1384159
Opened 7 years ago
Closed 7 years ago
Update SDWebImage to 4.0
Categories
(Firefox for iOS :: General, enhancement, P3)
Tracking
()
RESOLVED
FIXED
Iteration:
1.30
| Tracking | Status | |
|---|---|---|
| fxios | 10.0 | --- |
People
(Reporter: aaronmt, Assigned: garvan)
Details
(Whiteboard: [Dependencies])
Attachments
(1 file, 2 obsolete files)
We should update SDWebImage to 4.0
|
Reporter | |
Comment 1•7 years ago
|
||
|
|
Reporter | |
Updated•7 years ago
|
tracking-fxios:
--- → ?
|
|
Reporter | |
Comment 2•7 years ago
|
||
Over to the team to debug this compile error
https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/5977644efe869f0001f5ff30
https://github.com/rs/SDWebImage/blob/master/Docs/SDWebImage-4.0-Migration-guide.md
Per the changelog (https://github.com/rs/SDWebImage/blob/4.0.0/CHANGELOG.md) the dynamic framework name was changed from `WebImage` to `SDWebImage`. It seems they forgot to mention that in the migration guide.
|
||
Updated•7 years ago
|
Priority: -- → P3
|
||
Updated•7 years ago
|
Whiteboard: [Dependencies]
|
|
||
Updated•7 years ago
|
|
|
||
Updated•7 years ago
|
Attachment #8889908 -
Attachment is obsolete: true
Attachment #8909298 -
Flags: review?(jhugman)
Comment on attachment 8909298 [details] [review]
Pull request
Clearing review flag. It looks like I didn't check all the tests. For instance, BB is failing on StorageTests.
Attachment #8909298 -
Flags: review?(jhugman)
|
||
Comment 6•7 years ago
|
||
PR reviewed. Add r? when you want it re-reviewed
Thanks for review James, updated the PR
Attachment #8909298 -
Attachment is obsolete: true
Attachment #8909339 -
Flags: review?(jhugman)
|
|
||
Updated•7 years ago
|
Attachment #8909339 -
Flags: review?(jhugman) → review+
Comment on attachment 8909339 [details] [review]
Pull request
More changes were needed in test code (and I found some test code not hooked up as a result).
Marking for review of the last two commits on that PR, thanks!
Attachment #8909339 -
Flags: review+ → review?(jhugman)
|
|
||
Updated•7 years ago
|
Attachment #8909339 -
Flags: review?(jhugman) → review+
landed master and 10.x 4f76622d22ba80f0f2ea8ba0e9a465b855ff2939
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•