We should update SDWebImage to 4.0
Over to the team to debug this compile error https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/5977644efe869f0001f5ff30 https://github.com/rs/SDWebImage/blob/master/Docs/SDWebImage-4.0-Migration-guide.md
Per the changelog (https://github.com/rs/SDWebImage/blob/4.0.0/CHANGELOG.md) the dynamic framework name was changed from `WebImage` to `SDWebImage`. It seems they forgot to mention that in the migration guide.
Created attachment 8909298 [details] [review] Pull request
Comment on attachment 8909298 [details] [review] Pull request Clearing review flag. It looks like I didn't check all the tests. For instance, BB is failing on StorageTests.
PR reviewed. Add r? when you want it re-reviewed
Created attachment 8909339 [details] [review] Pull request Thanks for review James, updated the PR
Comment on attachment 8909339 [details] [review] Pull request More changes were needed in test code (and I found some test code not hooked up as a result). Marking for review of the last two commits on that PR, thanks!
landed master and 10.x 4f76622d22ba80f0f2ea8ba0e9a465b855ff2939