Closed Bug 1384159 Opened 7 years ago Closed 7 years ago

Update SDWebImage to 4.0

Categories

(Firefox for iOS :: General, enhancement, P3)

Other
iOS
enhancement

Tracking

()

RESOLVED FIXED
Iteration:
1.30
Tracking Status
fxios 10.0 ---

People

(Reporter: aaronmt, Assigned: garvan)

Details

(Whiteboard: [Dependencies])

Attachments

(1 file, 2 obsolete files)

55 bytes, text/x-github-pull-request
jhugman
: review+
Details | Review
We should update SDWebImage to 4.0
Attached file Update SDWebImage to 4.0.0 (obsolete) —
tracking-fxios: --- → ?
Per the changelog (https://github.com/rs/SDWebImage/blob/4.0.0/CHANGELOG.md) the dynamic framework name was changed from `WebImage` to `SDWebImage`. It seems they forgot to mention that in the migration guide.
Priority: -- → P3
Whiteboard: [Dependencies]
Assignee: nobody → gkeeley
Attached file Pull request (obsolete) —
Attachment #8889908 - Attachment is obsolete: true
Attachment #8909298 - Flags: review?(jhugman)
Comment on attachment 8909298 [details] [review]
Pull request

Clearing review flag. It looks like I didn't check all the tests. For instance, BB is failing on StorageTests.
Attachment #8909298 - Flags: review?(jhugman)
PR reviewed. Add r? when you want it re-reviewed
Attached file Pull request
Thanks for review James, updated the PR
Attachment #8909298 - Attachment is obsolete: true
Attachment #8909339 - Flags: review?(jhugman)
Attachment #8909339 - Flags: review?(jhugman) → review+
Iteration: --- → 1.30
Comment on attachment 8909339 [details] [review]
Pull request

More changes were needed in test code (and I found some test code not hooked up as a result).
Marking for review of the last two commits on that PR, thanks!
Attachment #8909339 - Flags: review+ → review?(jhugman)
Attachment #8909339 - Flags: review?(jhugman) → review+
landed master and 10.x 4f76622d22ba80f0f2ea8ba0e9a465b855ff2939
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: