Status

()

Firefox for iOS
General
P3
normal
RESOLVED FIXED
4 months ago
2 months ago

People

(Reporter: aaronmt, Assigned: garvan)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios10.0)

Details

(Whiteboard: [Dependencies])

Attachments

(1 attachment, 2 obsolete attachments)

55 bytes, text/x-github-pull-request
jhugman
: review+
Details | Review | Splinter Review
(Reporter)

Description

4 months ago
We should update SDWebImage to 4.0
(Reporter)

Comment 1

4 months ago
Created attachment 8889908 [details] [review]
Update SDWebImage to 4.0.0
(Reporter)

Updated

4 months ago
tracking-fxios: --- → ?
(Reporter)

Comment 2

4 months ago
Over to the team to debug this compile error

https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/5977644efe869f0001f5ff30

https://github.com/rs/SDWebImage/blob/master/Docs/SDWebImage-4.0-Migration-guide.md

Comment 3

4 months ago
Per the changelog (https://github.com/rs/SDWebImage/blob/4.0.0/CHANGELOG.md) the dynamic framework name was changed from `WebImage` to `SDWebImage`. It seems they forgot to mention that in the migration guide.

Updated

4 months ago
tracking-fxios: ? → 9.0
Priority: -- → P3

Updated

4 months ago
Whiteboard: [Dependencies]

Updated

2 months ago
tracking-fxios: 9.0 → 9.1
(Assignee)

Updated

2 months ago
Assignee: nobody → gkeeley

Updated

2 months ago
tracking-fxios: 9.1 → 10.0
(Assignee)

Comment 4

2 months ago
Created attachment 8909298 [details] [review]
Pull request
Attachment #8889908 - Attachment is obsolete: true
Attachment #8909298 - Flags: review?(jhugman)
(Assignee)

Comment 5

2 months ago
Comment on attachment 8909298 [details] [review]
Pull request

Clearing review flag. It looks like I didn't check all the tests. For instance, BB is failing on StorageTests.
Attachment #8909298 - Flags: review?(jhugman)
PR reviewed. Add r? when you want it re-reviewed
(Assignee)

Comment 7

2 months ago
Created attachment 8909339 [details] [review]
Pull request

Thanks for review James, updated the PR
Attachment #8909298 - Attachment is obsolete: true
Attachment #8909339 - Flags: review?(jhugman)
Attachment #8909339 - Flags: review?(jhugman) → review+
(Assignee)

Updated

2 months ago
Iteration: --- → 1.30
(Assignee)

Comment 8

2 months ago
Comment on attachment 8909339 [details] [review]
Pull request

More changes were needed in test code (and I found some test code not hooked up as a result).
Marking for review of the last two commits on that PR, thanks!
Attachment #8909339 - Flags: review+ → review?(jhugman)
Attachment #8909339 - Flags: review?(jhugman) → review+
(Assignee)

Comment 9

2 months ago
landed master and 10.x 4f76622d22ba80f0f2ea8ba0e9a465b855ff2939
(Assignee)

Updated

2 months ago
Status: NEW → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.