Closed Bug 1384204 Opened 7 years ago Closed 7 years ago

[Web Extension] webRequst listeners are not registered and fired for all Firefox web requests

Categories

(WebExtensions :: Request Handling, defect)

55 Branch
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1279371

People

(Reporter: oleksandr.oliynyk, Unassigned)

References

Details

Attachments

(1 file)

Attached file firefox-proxy-bug.zip
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36

Steps to reproduce:

# tested at Firefox Developer Edition v55

Short overview of the problem:
I am developing VPN extension. Our proxy server requires the authentication for all the requests. Attempts to add auth header to the request or provide auth credentials via webRequest.onAuthRequired failed for some requests.

Steps to reproduce:
1. Copy code from https://github.com/asashay/firefox-proxy-bug or extract from the attached archive
2. Go inside the folder and launch web extension either with 'web-ext run' command or visiting 'about:debugging' and adding extension there.
3. Make sure to check 'Turn on addons debugging' at the top
4. Press 'Ctr + Shift + Alt + I' or 'Debug' below extension name.
5. You will see developer console logging info about the requests from
- PAC script
- webRequest.onBeforeSendHeaders event
- webRequest.onCompleted event
6. Open new tab and start typing anything in the address bar


Actual results:

In the console you will see that browser is making requests to google.com, but they do not fire neither webRequest.onBeforeSendHeaders event nor webRequest.onCompleted event.

If you observe you will see that requests not only to "google.com" do not fire mentioned events but also:
http://clients1.google.com
https://safebrowsing.google.com
http://detectportal.firefox.com
http://ocsp.digicert.com
https://shavar.services.mozilla.com
and others

So we have situation when:
1. All requests go through PAC script
2. Some of them have webRequest listeners and some don't.


Expected results:

All requests from Firefox fire webRequest events: onBeforeSendHeaders, onCompleted, onAuthRequierd and others
Component: Untriaged → WebExtensions: Request Handling
Product: Firefox → Toolkit
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Hey, Kris.

Just trying to search anything in the address bar or search field near produces requests to 'https://www.google.com', 'https://safebrowsing-cache.google.com' and 'clients1.google.com' that do not fire webRequest events.

Do they really belong to update or OCSP checks requests (that we cannot access with webRequest events and listeners as stated in the bug you pointed me to)?

At the same time we are able to set PAC script that will affect all requests in the browser (including update or OCSP checks requests and the ones mentioned above) and can just block them.

Is this intended behavior either?
Won't it be more logical to not use PAC script for them at all?
Flags: needinfo?(kmaglione+bmo)
Those requests are not OCSP, but are still issued by the browser and not content, which means we don't allow webRequest listeners to listen on / modify those requests.

(blocking them via PAC may be subject to change later)
Flags: needinfo?(kmaglione+bmo)
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: