Closed
Bug 1384220
Opened 7 years ago
Closed 7 years ago
remove --with-crashreporter-enable-percent configure option
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox56 fixed)
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
7.59 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
This option was added ~decade ago; AFAICT from bug archaeology, the option was added to prevent our servers from being overwhelmed. Somewhere over the years, however, we obtained more capable servers and the option disappeared from mozconfigs. It seems moderately unlikely that we'll have a need for this option again, and we could reintroduce this patch very easily in any event. Let's go ahead and remove it.
Assignee | ||
Comment 1•7 years ago
|
||
Ted added the original option in bug 424960, and is guru of all things crash reporting, so he gets to evaluate the patch's goodness!
Attachment #8889981 -
Flags: review?(ted)
Comment 2•7 years ago
|
||
Comment on attachment 8889981 [details] [diff] [review] remove --with-crashreporter-enable-percent configure option Review of attachment 8889981 [details] [diff] [review]: ----------------------------------------------------------------- Yes, we throttle things server-side in Socorro these days (we only process a small percentage of reports from release builds).
Attachment #8889981 -
Flags: review?(ted) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d02f1a40367a remove --with-crashreporter-enable-percent configure option; r=ted.mielczarek
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d02f1a40367a
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•