remove --with-crashreporter-enable-percent configure option

RESOLVED FIXED in Firefox 56

Status

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla56

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

This option was added ~decade ago; AFAICT from bug archaeology, the
option was added to prevent our servers from being overwhelmed.
Somewhere over the years, however, we obtained more capable servers and
the option disappeared from mozconfigs.  It seems moderately unlikely
that we'll have a need for this option again, and we could reintroduce
this patch very easily in any event.  Let's go ahead and remove it.
Ted added the original option in bug 424960, and is guru of all things crash
reporting, so he gets to evaluate the patch's goodness!
Attachment #8889981 - Flags: review?(ted)
Comment on attachment 8889981 [details] [diff] [review]
remove --with-crashreporter-enable-percent configure option

Review of attachment 8889981 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, we throttle things server-side in Socorro these days (we only process a small percentage of reports from release builds).
Attachment #8889981 - Flags: review?(ted) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d02f1a40367a
remove --with-crashreporter-enable-percent configure option; r=ted.mielczarek
https://hg.mozilla.org/mozilla-central/rev/d02f1a40367a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.