1384257 - AttributeError: 'AutoTry' object has no attribute 'topobjdir'

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

If I add paths to the end of a mach try command, I see an AttributeError. Without the paths, it works fine. This is after doing a ./mach clobber && ./mach build.

./mach try -b do -p linux,linux64,macosx64,win64 -u web-platform-tests-1,web-platform-tests-e10s-1 testing/web-platform/tests/2dcontext/ testing/web-platform/tests/webdriver/ testing/web-platform/tests/cookies/ --no-push
Error running mach:

    ['try', '-b', 'do', '-p', 'linux,linux64,macosx64,win64', '-u', 'web-platform-tests-1,web-platform-tests-e10s-1', 'testing/web-platform/tests/2dcontext/', 'testing/web-platform/tests/webdriver/', 'testing/web-platform/tests/cookies/', '--no-push']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

AttributeError: 'AutoTry' object has no attribute 'topobjdir'

  File "/Users/mfrydrychowicz/dev/firefox/tools/tryselect/mach_commands.py", line 58, in try_default
    'try', subcommand='syntax', context=self._mach_context, **kwargs)
  File "/Users/mfrydrychowicz/dev/firefox/python/mach/mach/registrar.py", line 123, in dispatch
    return self._run_command_handler(handler, context=context, **kwargs)
  File "/Users/mfrydrychowicz/dev/firefox/python/mach/mach/registrar.py", line 90, in _run_command_handler
    result = fn(**kwargs)
  File "/Users/mfrydrychowicz/dev/firefox/tools/tryselect/mach_commands.py", line 118, in try_syntax
    return at.run(**kwargs)
  File "/Users/mfrydrychowicz/dev/firefox/tools/tryselect/selectors/syntax.py", line 732, in run
    if not os.path.exists(os.path.join(self.topobjdir, 'config.status')):

Comment 1

[Andrew Halberstadt [:ahal]]

Oops sorry about that.

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1384257 - Fix AttributeError when passing paths into |mach try|,

Review commit: https://reviewboard.mozilla.org/r/161092/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/161092/

Comment 3

[Andrew Halberstadt [:ahal]]

I have to step out for a bit soon, but feel free to autoland if it looks good.

Comment 4

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8890041 [details]
Bug 1384257 - Fix AttributeError when passing paths into |mach try|,

https://reviewboard.mozilla.org/r/161092/#review166428

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e6b995599dd
Fix AttributeError when passing paths into |mach try|, r=maja_zf

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8e6b995599dd