Closed
Bug 1384257
Opened 7 years ago
Closed 7 years ago
AttributeError: 'AutoTry' object has no attribute 'topobjdir'
Categories
(Testing :: General, defect)
Tracking
(firefox56 fixed)
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: impossibus, Assigned: ahal)
References
Details
Attachments
(1 file)
If I add paths to the end of a mach try command, I see an AttributeError. Without the paths, it works fine. This is after doing a ./mach clobber && ./mach build. ./mach try -b do -p linux,linux64,macosx64,win64 -u web-platform-tests-1,web-platform-tests-e10s-1 testing/web-platform/tests/2dcontext/ testing/web-platform/tests/webdriver/ testing/web-platform/tests/cookies/ --no-push Error running mach: ['try', '-b', 'do', '-p', 'linux,linux64,macosx64,win64', '-u', 'web-platform-tests-1,web-platform-tests-e10s-1', 'testing/web-platform/tests/2dcontext/', 'testing/web-platform/tests/webdriver/', 'testing/web-platform/tests/cookies/', '--no-push'] The error occurred in code that was called by the mach command. This is either a bug in the called code itself or in the way that mach is calling it. You should consider filing a bug for this issue. If filing a bug, please include the full output of mach, including this error message. The details of the failure are as follows: AttributeError: 'AutoTry' object has no attribute 'topobjdir' File "/Users/mfrydrychowicz/dev/firefox/tools/tryselect/mach_commands.py", line 58, in try_default 'try', subcommand='syntax', context=self._mach_context, **kwargs) File "/Users/mfrydrychowicz/dev/firefox/python/mach/mach/registrar.py", line 123, in dispatch return self._run_command_handler(handler, context=context, **kwargs) File "/Users/mfrydrychowicz/dev/firefox/python/mach/mach/registrar.py", line 90, in _run_command_handler result = fn(**kwargs) File "/Users/mfrydrychowicz/dev/firefox/tools/tryselect/mach_commands.py", line 118, in try_syntax return at.run(**kwargs) File "/Users/mfrydrychowicz/dev/firefox/tools/tryselect/selectors/syntax.py", line 732, in run if not os.path.exists(os.path.join(self.topobjdir, 'config.status')):
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(ahalberstadt)
Assignee | ||
Comment 1•7 years ago
|
||
Oops sorry about that.
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Flags: needinfo?(ahalberstadt)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
I have to step out for a bit soon, but feel free to autoland if it looks good.
Reporter | ||
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8890041 [details] Bug 1384257 - Fix AttributeError when passing paths into |mach try|, https://reviewboard.mozilla.org/r/161092/#review166428
Attachment #8890041 -
Flags: review?(mjzffr) → review+
Pushed by mjzffr@gmail.com: https://hg.mozilla.org/integration/autoland/rev/8e6b995599dd Fix AttributeError when passing paths into |mach try|, r=maja_zf
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8e6b995599dd
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•