Closed Bug 1384259 Opened 3 years ago Closed 3 years ago

[jsdbg2] Debugger.Frame.prototype.script makes unnecessary checks

Categories

(Core :: JavaScript Engine, enhancement, trivial)

enhancement
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: jimb, Assigned: jimb)

Details

Attachments

(1 file)

The DebuggerFrame_getScript function unnecessarily checks that an isFunctionFrame frame's callee isInterpreted. There is no way I know of for an isFunctionFrame to run a non-interpreted function; running the jit-test suite doesn't reveal any, either. This should be an assertion at best.
Assignee: nobody → jimb
Status: NEW → ASSIGNED
Attachment #8890031 - Flags: review?(ttromey)
Comment on attachment 8890031 [details] [diff] [review]
Remove unneeded checks from DebuggerFrame_getScript.

Review of attachment 8890031 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable to me.  Thanks.
Attachment #8890031 - Flags: review?(ttromey) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/71511633aae7
Remove unneeded checks from DebuggerFrame_getScript. r=ttromey
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/71511633aae7
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.