Closed
Bug 1384269
Opened 7 years ago
Closed 7 years ago
signoff revocation doesn't work when more than 1 signoff exists
Categories
(Release Engineering Graveyard :: Applications: Balrog (backend), enhancement, P2)
Release Engineering Graveyard
Applications: Balrog (backend)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
References
Details
Attachments
(1 file)
We end up with: Permission denied to perform the request. Cannot revoke a signoff made by someone in a group you do not belong to Looks like this is because https://github.com/mozilla/balrog/blob/efb35a236768cc1dac6a1335c1a743b92764a737/auslib/web/admin/views/scheduled_changes.py#L166 doesn't specify the user when constructing the "where" clause - so we try to remove all signoffs instead of just the one the user made.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8890390 -
Flags: review?(nthomas)
Updated•7 years ago
|
Attachment #8890390 -
Flags: review?(nthomas) → review+
Comment 2•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/balrog https://github.com/mozilla/balrog/commit/66586efb26f4bde95d25d0c648ae765f9893cf44 bug 1384269: Fix revocation when more than one signoff has already happened. (#356) r=nthomas
Assignee | ||
Updated•7 years ago
|
Priority: -- → P2
Assignee | ||
Comment 3•7 years ago
|
||
This is in production.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updated•4 years ago
|
Product: Release Engineering → Release Engineering Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•