signoff revocation doesn't work when more than 1 signoff exists

RESOLVED FIXED

Status

P2
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: bhearsum, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We end up with: Permission denied to perform the request. Cannot revoke a signoff made by someone in a group you do not belong to

Looks like this is because https://github.com/mozilla/balrog/blob/efb35a236768cc1dac6a1335c1a743b92764a737/auslib/web/admin/views/scheduled_changes.py#L166 doesn't specify the user when constructing the "where" clause - so we try to remove all signoffs instead of just the one the user made.
Created attachment 8890390 [details] [review]
fix revocation when multiple signoffs have already happened
Attachment #8890390 - Flags: review?(nthomas)
Attachment #8890390 - Flags: review?(nthomas) → review+

Comment 2

a year ago
Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/66586efb26f4bde95d25d0c648ae765f9893cf44
bug 1384269: Fix revocation when more than one signoff has already happened. (#356) r=nthomas
(Assignee)

Updated

a year ago
Priority: -- → P2
(Assignee)

Updated

a year ago
Depends on: 1390197
This is in production.
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.