1384281 - Update Screenshots to version 10.9.0

Status: RESOLVED FIXED

(Firefox :: Screenshots, defect)

Description

[Ian Bicking (:ianbicking)]

Only one change in this version:

* Remove Save Full Page and Save Visible https://github.com/mozilla-services/screenshots/pull/3208 - Avoids https://github.com/mozilla-services/screenshots/issues/3182

Comment 1

[Ian Bicking (:ianbicking)]

Attachment: Bug 1384281 - Export Screenshots 10.9.0 to Firefox;

Review commit: https://reviewboard.mozilla.org/r/161156/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/161156/

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8890084 [details]
Bug 1384281 - Export Screenshots 10.9.0 to Firefox;

https://reviewboard.mozilla.org/r/161156/#review166532

::: browser/extensions/screenshots/webextension/selector/ui.js
(Diff revision 1)
> -            overlay.querySelector(".visible").textContent = browser.i18n.getMessage("saveScreenshotVisibleArea");
> -            overlay.querySelector(".full-page").textContent = browser.i18n.getMessage("saveScreenshotFullPage");

Should these locale strings also be removed?

Comment 3

[Ian Bicking (:ianbicking)]

Comment on attachment 8890084 [details]
Bug 1384281 - Export Screenshots 10.9.0 to Firefox;

https://reviewboard.mozilla.org/r/161156/#review166534

::: browser/extensions/screenshots/webextension/selector/ui.js
(Diff revision 1)
> -            overlay.querySelector(".visible").textContent = browser.i18n.getMessage("saveScreenshotVisibleArea");
> -            overlay.querySelector(".full-page").textContent = browser.i18n.getMessage("saveScreenshotFullPage");

We've only done an extremely minimal removal of the feature (all the code related to the feature is also still in the product) – we did it this way due to the late date, and because we plan to bring the feature back in the next release of Screenshots.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a7e5b833c4b
Export Screenshots 10.9.0 to Firefox; r=kmag

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

We need to uplift this in 56 before we go live, tracked as blocking.

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

(In reply to Ritu Kothari (:ritu) from comment #5)
> We need to uplift this in 56 before we go live, tracked as blocking.

I meant 55!

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7a7e5b833c4b

Comment 8

[Ian Bicking (:ianbicking)]

Comment on attachment 8890084 [details]
Bug 1384281 - Export Screenshots 10.9.0 to Firefox;

Approval Request Comment
[Feature/Bug causing the regression]:
Long-delayed shot creation on Imgur and Giphy: https://github.com/mozilla-services/screenshots/issues/3182

[User impact if declined]:
Users who use the Full Page screenshot feature will see a feature that is very slow.

[Is this code covered by automated tests?]:
No

[Has the fix been verified in Nightly?]:
Yes (by SoftVision)

[Needs manual test from QE? If yes, steps to reproduce]: 
No

[List of other uplifts needed for the feature/fix]:
None

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
It just hides the buttons for taking full page or visible screenshots, it otherwise doesn't change the code.

[String changes made/needed]:
None

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 8890084 [details]
Bug 1384281 - Export Screenshots 10.9.0 to Firefox;

disable full page screenshots, beta55+, for 55.0b13

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/64d46a73fab4