Update Screenshots to version 10.9.0

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Screenshots
RESOLVED FIXED
a year ago
10 months ago

People

(Reporter: ianbicking, Assigned: ianbicking)

Tracking

unspecified
Firefox 56
Points:
---

Firefox Tracking Flags

(firefox55blocking fixed, firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Only one change in this version:

* Remove Save Full Page and Save Visible https://github.com/mozilla-services/screenshots/pull/3208 - Avoids https://github.com/mozilla-services/screenshots/issues/3182
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8890084 - Flags: review?(dtownsend) → review?(kmaglione+bmo)

Comment 2

a year ago
mozreview-review
Comment on attachment 8890084 [details]
Bug 1384281 - Export Screenshots 10.9.0 to Firefox;

https://reviewboard.mozilla.org/r/161156/#review166532

::: browser/extensions/screenshots/webextension/selector/ui.js
(Diff revision 1)
> -            overlay.querySelector(".visible").textContent = browser.i18n.getMessage("saveScreenshotVisibleArea");
> -            overlay.querySelector(".full-page").textContent = browser.i18n.getMessage("saveScreenshotFullPage");

Should these locale strings also be removed?
Attachment #8890084 - Flags: review?(kmaglione+bmo) → review+
(Assignee)

Comment 3

a year ago
mozreview-review
Comment on attachment 8890084 [details]
Bug 1384281 - Export Screenshots 10.9.0 to Firefox;

https://reviewboard.mozilla.org/r/161156/#review166534

::: browser/extensions/screenshots/webextension/selector/ui.js
(Diff revision 1)
> -            overlay.querySelector(".visible").textContent = browser.i18n.getMessage("saveScreenshotVisibleArea");
> -            overlay.querySelector(".full-page").textContent = browser.i18n.getMessage("saveScreenshotFullPage");

We've only done an extremely minimal removal of the feature (all the code related to the feature is also still in the product) – we did it this way due to the late date, and because we plan to bring the feature back in the next release of Screenshots.
(Assignee)

Updated

a year ago
Keywords: checkin-needed

Comment 4

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7a7e5b833c4b
Export Screenshots 10.9.0 to Firefox; r=kmag
Keywords: checkin-needed
We need to uplift this in 56 before we go live, tracked as blocking.
status-firefox56: --- → affected
tracking-firefox56: --- → blocking
(In reply to Ritu Kothari (:ritu) from comment #5)
> We need to uplift this in 56 before we go live, tracked as blocking.

I meant 55!
status-firefox55: --- → affected
status-firefox56: affected → ---
tracking-firefox55: --- → blocking
tracking-firefox56: blocking → ---

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7a7e5b833c4b
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
(Assignee)

Comment 8

a year ago
Comment on attachment 8890084 [details]
Bug 1384281 - Export Screenshots 10.9.0 to Firefox;

Approval Request Comment
[Feature/Bug causing the regression]:
Long-delayed shot creation on Imgur and Giphy: https://github.com/mozilla-services/screenshots/issues/3182

[User impact if declined]:
Users who use the Full Page screenshot feature will see a feature that is very slow.

[Is this code covered by automated tests?]:
No

[Has the fix been verified in Nightly?]:
Yes (by SoftVision)

[Needs manual test from QE? If yes, steps to reproduce]: 
No

[List of other uplifts needed for the feature/fix]:
None

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
It just hides the buttons for taking full page or visible screenshots, it otherwise doesn't change the code.

[String changes made/needed]:
None
Attachment #8890084 - Flags: approval-mozilla-beta?
Comment on attachment 8890084 [details]
Bug 1384281 - Export Screenshots 10.9.0 to Firefox;

disable full page screenshots, beta55+, for 55.0b13
Attachment #8890084 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 10

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/64d46a73fab4
status-firefox55: affected → fixed
Target Milestone: --- → mozilla56
Target Milestone: mozilla56 → Firefox 56

Updated

10 months ago
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.