1384297 - Add treeherder job mapping support for new tp6 jobs

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Data Ingestion, enhancement)

Description

[Robert Wood [:rwood]]

In Bug 1383737 we are changing the talos quantum-pageload test names to tp6* and also the corresponding job symbols from 'q1x' to 'tp6x'. The treeherder data ingestion job mapping will need to be updated accordingly.

We also will be adding a new tp6 test variation for stylo-threads (tp6st), which will also require treeherder job mappings, so I will add that in this patch also.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] rwood-moz:bug1384297 > mozilla:master

Comment 2

[Robert Wood [:rwood]]

Comment on attachment 8890376 [details] [review]
[treeherder] rwood-moz:bug1384297 > mozilla:master

Have the existing 'quantum-pageload' jobs map to the new 'tp6' symbols, and also have the new 'tp6-stylo-threads' job map to 'tp6st'.

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 8890376 [details] [review]
[treeherder] rwood-moz:bug1384297 > mozilla:master

The symbol renamed might break some things (or at least require some DB manipulation) - Cameron could you take a look? :-)

Comment 4

[Ed Morley [:emorley]]

s/renamed/rename/

Comment 5

[Cameron Dawson [:camd]]

Comment on attachment 8890376 [details] [review]
[treeherder] rwood-moz:bug1384297 > mozilla:master

These will actually be fine and won't require any DB surgery.  Since they're a new JobType name and symbol, they will just get new JobType table entry.  

However, it won't change any of the old jobs that are already ingested.  If you need those changed to this new type, then it WILL require some DB surgery.  Hopefully that's not the case, though.

Rob, as I recall, you are able to merge on your own.  But let me know if you need me to.

Comment 6

[Robert Wood [:rwood]]

(In reply to Cameron Dawson [:camd] from comment #5)
> Comment on attachment 8890376 [details] [review]
> [treeherder] rwood-moz:bug1384297 > mozilla:master
> 
> These will actually be fine and won't require any DB surgery.  Since they're
> a new JobType name and symbol, they will just get new JobType table entry.  
> 
> However, it won't change any of the old jobs that are already ingested.  If
> you need those changed to this new type, then it WILL require some DB
> surgery.  Hopefully that's not the case, though.

No that's not necessary, thanks for the review!

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/cab2c53ee59b67a8a98d857496a29975fddcf9c6
Bug 1384297 - Add treeherder job mapping support for new tp6 jobs (#2659)