Closed Bug 1384358 Opened 2 years ago Closed 2 years ago

Intermittent dom/tests/browser/browser_focus_steal_from_chrome_during_mousedown.js | The input element isn't active element: button=0 - "body" == "willBeFocused" -

Categories

(Core :: DOM: Core & HTML, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox58 --- fixed
firefox59 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: Nika)

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell unknown])

Attachments

(1 file)

In the last 7 days there have been 45 failures. 
Most of the failures occur on the linux x64 platform. There are also some failures that occur on linux and windows 7 platforms and very low number (1 to 3 failures) on other platforms like: linux32-stylo-disabled, linux64-stylo-disabled, windows10-64-stylo-disabled, windows7-32-stylo-disabled, windows7-32-nightly.

The failures mostly occur on the opt build type, but there are some on pgo too and a single failure on debug.



:overholt, could you please take a look?
Flags: needinfo?(overholt)
Nika touched this patch a year or so ago so maybe has some ideas :)
Flags: needinfo?(overholt) → needinfo?(nika)
Priority: -- → P2
Flags: needinfo?(nika)
Previously this was safe, as the synthesized mouse event would be processed in
the child process, updating the focus state, in order - before the content
process would try to check its focus state. Now, thanks to multiple event queues
work, this isn't guaranteed.

This patch just adds retrying to the logic, so we retry up to 10 times, 100ms
apart. This should ensure that we don't incorrectly detect a test failure
intermittently.

MozReview-Commit-ID: J4uzl9jeafC
Attachment #8927951 - Flags: review?(enndeakin)
Comment on attachment 8927951 [details] [diff] [review]
Avoid racy check of focus manager in content process

Review of attachment 8927951 [details] [diff] [review]:
-----------------------------------------------------------------

Seems fine for now, but in the long run we probably want 1240052 to be implemented.
Attachment #8927951 - Flags: review?(enndeakin) → review+
Assignee: nobody → nika
Pushed by nika@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/07d87a46d621
Avoid racy check of focus manager in content process, r=enndeakin
https://hg.mozilla.org/mozilla-central/rev/07d87a46d621
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.