Closed Bug 1384405 Opened 3 years ago Closed 3 years ago

Dump the request payload to check 400s response from server V2

Categories

(Toolkit :: Safe Browsing, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: tnguyen, Assigned: dimi)

References

Details

Attachments

(1 file)

See Also: → 1381718
Priority: -- → P5
Bumping the priority, we should really do this :)
Priority: P5 → P2
Assignee: nobody → dlee
Status: NEW → ASSIGNED
Comment on attachment 8914569 [details]
Bug 1384405 - Dump request payload for V2 400 responses.

https://reviewboard.mozilla.org/r/185870/#review191218

::: commit-message-e1f66:1
(Diff revision 2)
> +Bug 1384405 - Dump the request payload to check 400s response from server V2. r?francois

nit: I would rephrase that to "Dump request payload for V2 400 responses."

::: commit-message-e1f66:4
(Diff revision 2)
> +Bug 1384405 - Dump the request payload to check 400s response from server V2. r?francois
> +
> +Refactor SafeBrowsing code so we can get the payload of gethash/update request when
> +update fail.

"updates"

::: toolkit/components/url-classifier/nsUrlClassifierStreamUpdater.h:83
(Diff revision 2)
> +    nsCString mUrl;
> +    nsCOMPtr<nsIUrlClassifierCallback> mSuccessCallback;
> +    nsCOMPtr<nsIUrlClassifierCallback> mUpdateErrorCallback;
> +    nsCOMPtr<nsIUrlClassifierCallback> mDownloadErrorCallback;
> +  };
> +  // Utility function to create an update request.  

nit: trailing whitespace
Attachment #8914569 - Flags: review?(francois) → review+
Pushed by dlee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b732a613733c
Dump request payload for V2 400 responses. r=francois
https://hg.mozilla.org/mozilla-central/rev/b732a613733c
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.