Closed
Bug 1384405
Opened 7 years ago
Closed 7 years ago
Dump the request payload to check 400s response from server V2
Categories
(Toolkit :: Safe Browsing, enhancement, P2)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: tnguyen, Assigned: dlee)
References
Details
Attachments
(1 file)
Telemetry shows server v2 does not return 400 https://telemetry.mozilla.org/new-pipeline/dist.html#!cumulative=0&end_date=2017-07-24&keys=google4!mozilla!mozilla!google&max_channel_version=nightly%252F56&measure=URLCLASSIFIER_UPDATE_REMOTE_STATUS2&min_channel_version=null&processType=*&product=Firefox&sanitize=1&sort_keys=submissions&start_date=2017-06-12&table=0&trim=1&use_submission_date=0 But, follow up bug 1381718 it maybe still worth to add the payload debug in case 400 v2
Reporter | ||
Updated•7 years ago
|
Priority: -- → P5
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → dlee
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8914569 [details] Bug 1384405 - Dump request payload for V2 400 responses. https://reviewboard.mozilla.org/r/185870/#review191218 ::: commit-message-e1f66:1 (Diff revision 2) > +Bug 1384405 - Dump the request payload to check 400s response from server V2. r?francois nit: I would rephrase that to "Dump request payload for V2 400 responses." ::: commit-message-e1f66:4 (Diff revision 2) > +Bug 1384405 - Dump the request payload to check 400s response from server V2. r?francois > + > +Refactor SafeBrowsing code so we can get the payload of gethash/update request when > +update fail. "updates" ::: toolkit/components/url-classifier/nsUrlClassifierStreamUpdater.h:83 (Diff revision 2) > + nsCString mUrl; > + nsCOMPtr<nsIUrlClassifierCallback> mSuccessCallback; > + nsCOMPtr<nsIUrlClassifierCallback> mUpdateErrorCallback; > + nsCOMPtr<nsIUrlClassifierCallback> mDownloadErrorCallback; > + }; > + // Utility function to create an update request. nit: trailing whitespace
Attachment #8914569 -
Flags: review?(francois) → review+
Comment hidden (mozreview-request) |
Pushed by dlee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b732a613733c Dump request payload for V2 400 responses. r=francois
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b732a613733c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•