Migrate cctools-port to toolchain dependencies

RESOLVED FIXED in Firefox 56

Status

enhancement
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla56
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

2 years ago
No description provided.
Assignee

Comment 1

2 years ago
Data for the migration helper attached to bug 1313111:
KNOWN_TOOLCHAINS = {
    'linux64-cctools-port': '0b962ba55a5a',
}
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 4

2 years ago
mozreview-review
Comment on attachment 8890215 [details]
Bug 1384421 - Use toolchain dependencies for cctools-port.

https://reviewboard.mozilla.org/r/161318/#review166626

At some point we may want to define these in a transform. But I do like verbosity over magic as long as things aren't too verbose.
Attachment #8890215 - Flags: review?(gps) → review+

Comment 5

2 years ago
mozreview-review
Comment on attachment 8890216 [details]
Bug 1384421 - Remove cctools-port entries from tooltool manifests.

https://reviewboard.mozilla.org/r/161320/#review166628
Attachment #8890216 - Flags: review?(gps) → review+
Assignee

Comment 6

2 years ago
(In reply to Gregory Szorc [:gps] from comment #4)
> Comment on attachment 8890215 [details]
> Bug 1384421 - Use toolchain dependencies for cctools-port.
> 
> https://reviewboard.mozilla.org/r/161318/#review166626
> 
> At some point we may want to define these in a transform. But I do like
> verbosity over magic as long as things aren't too verbose.

At the moment, I'm merely making things equal to what we do with tooltool, but there are some that can be removed. Like a number of jobs don't actually need the gcc dependency. Once that cleanup is done, we can think about nicer ways to define those toolchains.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 9

2 years ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/41f8f74d967e
Use toolchain dependencies for cctools-port. r=gps
https://hg.mozilla.org/integration/autoland/rev/f8a082c113b9
Remove cctools-port entries from tooltool manifests. r=gps

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/41f8f74d967e
https://hg.mozilla.org/mozilla-central/rev/f8a082c113b9
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56

Updated

Last year
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.