138444 - attribute SELECTED is changed while saving to SELECTED=""

Status: VERIFIED DUPLICATE of bug 88761

(Core :: DOM: Serializers, defect)

Description

[Adam Hauner]

2002041711/RC1/Win2K

Repro: 
1. open testcase
2. save page as 'Web Page, complete'

Actual:
OPTION attribute SELECTED is changed while saving to SELECTED="".

Expect:
Not change attribute, because it's incorrect for HTML4.01.

Comment 1

[Adam Hauner]

Attachment: testcase

Comment 2

[Chris Casciano]

Looking for an explanation between the difference between "save as web page HTML
only" an and "save as web page complete", but the jist of it is that when saving
the complete page the parsed document is saved along with changes that are
needed for local viewing. This IS NOT the document byte for byte that was sent
to the browser to begin with.

Potentially WONTFIX.

Comment 3

[Adam Hauner]

Attachment: Updated testcase

Added DOCTYPE.

Comment 4

[Adam Hauner]

I haven't problem with 'browser is changing source-code', but with 'Mozilla
turns strictly correct HTML 4.01 code to something incorrect'. Saved page don't
validate as HTML 4.01, but original validate.

Comment 5

[Boris Zbarsky [:bzbarsky]]

This is a document encoder issue.... we should change to SELECTED="SELECTED"

To DOM-to-text-conversion

Comment 6

[Tanu Mutreja]

-->Myself.

Comment 7

[Tanu Mutreja]

In mozilla/content/base/src/nsHTMLContentSerializer.cpp, method(line# 314) 

void nsHTMLContentSerializer::SerializeAttributes(nsIContent* aContent,
                                                  nsIAtom*
aTagName,                        
                                                  nsAString& aStr)
adding the following at line#361, as an extra condition solves this problem: 


    if ((attrName.get() == nsHTMLAtoms::selected) && valueStr.IsEmpty()){
      valueStr = NS_LITERAL_STRING("selected");
    }

For more clarity, next I'm attaching a text file that contains the modified
method as a whole. I'd be thankful if someone can incorporate this change and
provide a proper patch with the diff.

Comment 8

[Tanu Mutreja]

Attachment: Modified Method For Fixing This Bug...

Comment 9

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Hmm, I think this is a dupe, and peterv already has a fix.

*** This bug has been marked as a duplicate of 88761 ***

Comment 10

[sujay]

verified.