Closed Bug 1384509 Opened 7 years ago Closed 7 years ago

Stop using preprocessor in nsURLFormatter.js

Categories

(Toolkit :: General, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(2 files, 1 obsolete file)

Can we stop using the preprocessor in nsURLFormatter.js? Any ideas on how to do it?
Flags: needinfo?(dtownsend)
Moving the defines we need into AppConstants.jsm is generally the route we take.
Flags: needinfo?(dtownsend)
Blocks: 1381972
Attached patch Patch (obsolete) — Splinter Review
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #8890607 - Flags: review?(dtownsend)
Attached patch TestSplinter Review
Attachment #8890609 - Flags: review?(dtownsend)
Attached patch PatchSplinter Review
Forgot to remove now unused `api_keys.in` file.
Attachment #8890607 - Attachment is obsolete: true
Attachment #8890607 - Flags: review?(dtownsend)
Attachment #8890617 - Flags: review?(dtownsend)
Attachment #8890617 - Flags: review?(dtownsend) → review+
Attachment #8890609 - Flags: review?(dtownsend) → review+
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a8da9b73bc8
Move Bing, Google, Mozilla API key definitions to AppConstants.jsm and stop using preprocessor in nsURLFormatter.js. r=mossop
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a6137337416
Test replacing *_API_KEY variables in URLs using the URL formatter and test trimming sensitive URLs. r=mossop
https://hg.mozilla.org/mozilla-central/rev/0a8da9b73bc8
https://hg.mozilla.org/mozilla-central/rev/9a6137337416
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.