Closed Bug 1384511 Opened 4 years ago Closed 4 years ago
about:telemetry histograms section shows wrong histograms
59 bytes, text/x-review-board-request
When going to about:telemetry, then selecting a section for which no histograms are available, it will break (or after bug 1302681 fall back to the parent ones). https://dxr.mozilla.org/mozilla-central/rev/7d2e89fb92331d7e4296391213c1e63db628e046/toolkit/content/aboutTelemetry.js#2085 This needs some cleanup: - the section "hasData" when *any* of `payload.parent.histograms` or `payload.processes.<P>.histograms` exist and are non-empty - this should not fall back to the parent histograms - for empty processes this should either 1) disable the process entry or 2) just show empty tables
The same goes for the keyed histograms section.
Comment on attachment 8891396 [details] Bug 1384511 - Display the correct histograms in about:telemetry https://reviewboard.mozilla.org/r/162564/#review167838 Looks like it should work.
Attachment #8891396 - Flags: review?(chutten) → review+
(In reply to flyingrub from comment #2) > Created attachment 8891396 [details] > Bug 1384511 - Display the correct histograms in about:telemetry > > Fix "has-data" for all section that uses the process select. > Display no histograms when the current process hasn't any data and not > the parent ones. Does this mean i should drop the "part 2" patch in bug 1302681?
Yup, I think it will probably only causes merge conflicts :S
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/ceb431d84aab Display the correct histograms in about:telemetry r=chutten
You need to log in before you can comment on or make changes to this bug.