about:telemetry histograms section shows wrong histograms

RESOLVED FIXED in Firefox 56

Status

()

Toolkit
Telemetry
P1
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: gfritzsche, Assigned: flyingrub)

Tracking

(Blocks: 1 bug)

Trunk
mozilla56
Points:
1
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

When going to about:telemetry, then selecting a section for which no histograms are available, it will break (or after bug 1302681 fall back to the parent ones).

https://dxr.mozilla.org/mozilla-central/rev/7d2e89fb92331d7e4296391213c1e63db628e046/toolkit/content/aboutTelemetry.js#2085

This needs some cleanup:
- the section "hasData" when *any* of `payload.parent.histograms` or `payload.processes.<P>.histograms` exist and are non-empty
- this should not fall back to the parent histograms
- for empty processes this should either 1) disable the process entry or 2) just show empty tables
The same goes for the keyed histograms section.
(Assignee)

Updated

4 months ago
Assignee: nobody → flyinggrub
Blocks: 1384534
(Assignee)

Updated

4 months ago
Priority: P2 → P1
Comment hidden (mozreview-request)

Comment 3

4 months ago
mozreview-review
Comment on attachment 8891396 [details]
Bug 1384511 - Display the correct histograms in about:telemetry

https://reviewboard.mozilla.org/r/162564/#review167838

Looks like it should work.
Attachment #8891396 - Flags: review?(chutten) → review+
(Assignee)

Updated

4 months ago
Keywords: checkin-needed
(In reply to flyingrub from comment #2)
> Created attachment 8891396 [details]
> Bug 1384511 - Display the correct histograms in about:telemetry
> 
> Fix "has-data" for all section that uses the process select.
> Display no histograms when the current process hasn't any data and not
> the parent ones.

Does this mean i should drop the "part 2" patch in bug 1302681?
Flags: needinfo?(flyinggrub)
(Assignee)

Comment 5

4 months ago
Yup, I think it will probably only causes merge conflicts :S
Flags: needinfo?(flyinggrub)

Comment 6

4 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ceb431d84aab
Display the correct histograms in about:telemetry r=chutten
Keywords: checkin-needed

Comment 7

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ceb431d84aab
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.