1384554 - Main tab names from preferences are not visible on Windows 7, when using a High Contrast theme

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Deac Alin]

Attachment: High Contrast issue win 7.png

[Affected versions]: 
Nightly 56.0a1, Build ID 20170723100358

[Affected platforms]:
Platforms: Windows 7 x 64 

[Steps to reproduce]:
1. In Windows 7 go to Control Panel\All Control Panel Items\Personalization and select High Contrast Theme
2. Launch Nightly
3. Go to "about:preferences" and check the main tabs content
4. Go to Firefox Account tab

[Expected result]:
Preferences main Tabs(Icon and name) should be properly displayed on Windows 7, when using a High contrast theme (screenshot section 2)
Android and iOS Logos are properly displayed when using a High contrast theme(screenshot section 3)

[Actual result]:
Main Tabs names from preferences are not visible on Windows 7, when using a High Contrast theme
Android and iOS Logos are not visible when using a High contrast theme

Also, please note that the "Privacy & Security" tab icon and name is not visible at all when High Contrast theme is enabled(screenshot section 1)

For more details please check the attached screenshot. Thank you

Comment 1

[Deac Alin]

I am not sure if this issue is a Photon Preferences bug, but please take a look. Thank you.

Comment 2

[Evan Tseng [:evanxd]]

Attachment: Bug 1384554 - Use list-style-image style for images to support high contrast mode.

Review commit: https://reviewboard.mozilla.org/r/162000/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/162000/

Comment 3

[Evan Tseng [:evanxd]]

Comment on attachment 8890796 [details]
Bug 1384554 - Use list-style-image style for images to support high contrast mode.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/162000/diff/1-2/

Comment 4

[Evan Tseng [:evanxd]]

Hi Mike,

Could you review the patch?

Thank you.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8890796 [details]
Bug 1384554 - Use list-style-image style for images to support high contrast mode.

https://reviewboard.mozilla.org/r/162000/#review167406

Seems okay, but you might want to do [a screenshot comparison](https://developer.mozilla.org/en-US/docs/Mozilla/QA/Browser_screenshots) on try.

::: browser/themes/windows/preferences/in-content-new/preferences.css
(Diff revision 2)
> -  #category-application > .category-icon {
> -    list-style-image: url("chrome://browser/skin/preferences/in-content-new/icons.svg#applications-native");
> -  }
> -
>    #category-privacy > .category-icon {
> -    list-style-image: url("chrome://browser/skin/preferences/in-content-new/icons.svg#privacy-native");
> +    list-style-image: url("chrome://browser/skin/preferences/in-content-new/icons.svg#security-native");
>    }
>  
>    #category-sync > .category-icon {
>      list-style-image: url("chrome://browser/skin/preferences/in-content-new/icons.svg#sync-native");
>    }
>  
> -  #category-advanced > .category-icon {
> -    list-style-image: url("chrome://browser/skin/preferences/in-content-new/icons.svg#advanced-native");
> +  #category-search > .category-icon {
> +    list-style-image: url("chrome://browser/skin/preferences/in-content-new/icons.svg#search-native");
> -  }
> -
> -  #category-search-results > .category-icon {
> -    list-style-image: url("chrome://browser/skin/preferences/in-content-new/icons.svg#searchResults-native");

I guess these are kinda unrelated fix-ups since bug 1377163 landed?

Comment 6

[Evan Tseng [:evanxd]]

Thank you for reviewing, Mike. We'll verify the change.

Hi Ricky,

Could you help verify it since I'm still busy on working other bugs.

Thank you.

Comment 7

[Ricky Chien [:rickychien] (inactive)]

I've verified this patch on Windows 10. Those reported high contrast theme issues are fixed. Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18525ab19366
Use list-style-image style for images to support high contrast mode. r=mconley

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/18525ab19366

Comment 11

[Deac Alin]

Tested on Windows 7 x 64, with FF Nightly 56.0a1(2017-07-30). The issue is not reproducible. I will mark this as Verified Fixed. Thank you