Closed Bug 1384608 Opened 6 years ago Closed 6 years ago

Disabled Complete themes are not displayed in Legacy Extensions tab

Categories

(Toolkit :: Add-ons Manager, defect, P2)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox54 --- unaffected
firefox55 --- disabled
firefox56 --- wontfix
firefox57 --- verified

People

(Reporter: vtamas, Assigned: aswan)

References

Details

Attachments

(2 files)

Animation.gif
2.08 MB, image/gif
Details
Bug 1384608 Show complete themes with legacy extensions
59 bytes, text/x-review-board-request
rhelmer
: review+
Details
Attached image Animation.gif — 
[Note]: 
This is a follow-up for Bug 1373449

[Affected versions]:
Firefox 56.0a1 (2017-07-26)

[Affected platforms]:
Windows 10 64-bit
Mac OS X 10.12.3

[Steps to reproduce]:
1.Launch Firefox with a clean profile.
2.Install several complete themes from https://addons.mozilla.org/en-US/firefox/complete-themes/
3.Enable the “Default” theme and restart the browser.
4.Navigate to about:config and toggle "extensions.legacy.enabled” pref to false.
5.Restart the browser.
6.Go to about:addons and check the complete themes.


[Expected Results]:
Disabled complete themes are displayed in Legacy Extensions tab since they are treated as legacy add-ons.


[Actual Results]:
- “Legacy Extensions” tab does not appear and disabled complete themes are not displayed at all in Add-ons Manager even though “Missing something? Some extensions are no longer supported by Firefox. Show legacy extensions” banner is shown in “Appearance” tab.
- Clicking on "Show legacy extensions" link will display only the "Legacy extensions" icon but the tab is not loaded
- See attached screencast.
Assignee: nobody → aswan
Priority: -- → P2
I'm actually not sure what's desired here, complete themes are not extensions.  What should we do with them Markus?
Flags: needinfo?(mjaritz)
Please show them in the Legacy Extensions category. This might enable people to find replacements. (even though it is not 100% technically correct.) Maybe they like getting a nice looking working theme as a replacement.
Flags: needinfo?(mjaritz)
Amy/Scott: see comment 2, will the "find a replacement" button do something useful with complete themes?
Flags: needinfo?(sdevaney)
Flags: needinfo?(atsay)
Talking with Kev about this he agrees that we should use this to remove complete themes from the theme category, and use the page the "Find Replacement" button leads to, to direct people to Firefox built in Dark Theme. (As all of the most used complete themes are dark themes)
Jorge, can you ensure that there will be a page for those complete themes that offers that replacement.
Flags: needinfo?(jorge)
The Dark Theme isn't listed on AMO, as far as I know, so I don't know exactly what we would direct users to.

We'll probably need to make some code changes to the tool, since it sounds we want anything that resolves to a complete theme to go to a specific page. What page that is remains to be solved (the lightweight themes landing page is a possibility, though not a great one).
Flags: needinfo?(jorge)
What about this as a dark theme replacement rec?:

https://addons.mozilla.org/firefox/addon/dark-mode-webextension/
Flags: needinfo?(sdevaney)
As far as I can tell, that extension only changes web content. I doesn't use the themeing API.
(In reply to Jorge Villalobos [:jorgev] from comment #5)
> The Dark Theme isn't listed on AMO, as far as I know, so I don't know
> exactly what we would direct users to.

A message / image that informs people about the Firefox built in dark theme would be great. 
(As this theme will most likely also affect the background color of inContent pages, and with that be a truly dark theme.)
And we could maybe also show some popular lightweight themes on that page.
Is there a bug and a timeline for the AMO side of this?
Flags: needinfo?(jorge)
I think AMO got way more time to get that in for 57 than Firefox has. 
(And if we can't get that in for 57, it has lost most of it's effect.)
(In reply to Markus Jaritz [:designakt] (UX) from comment #10)
> I think AMO got way more time to get that in for 57 than Firefox has. 

Perhaps.  But remember, ~100K Nightly users are already using 57 and in late September, many more Beta users will be using it.
I'm not sold on creating a custom page just for complete themes, especially because it means creating new content in the old front-end which will only work temporarily. I'd rather send everyone to the lightweight theme landing page. I'll discuss this further with kev.
Flags: needinfo?(jorge)
Kev suggested sending users to a SUMO page explaining what's going on with complete themes and how to use the built-in themes in Firefox. I think that's a good idea, so I'll see if I can get that SUMO page done soon.
ni Joni for the SUMO content request.
Flags: needinfo?(atsay) → needinfo?(jsavage)
So if we want users to end up at SUMO, do we want them to go through Legacy Extensions -> Find a Replacement -> AMO -> SUMO?  Or just have a link straight to SUMO from the "Appearances" pane in about:addons if the user had a complete theme installed?
I think that's a better solution, yes. It would also require not showing the Find a Replacement button for Complete Themes.
Markus is on PTO for another week.  I've got a bunch of other bugs in front of me right now so I'm just going to wait for him to get back to make a final decision on exactly what we want here.
Assignee: aswan → nobody
SUMO to explain what alternatives people have to replace their complete theme sounds great. I would love for that page to explain that complete themes aren't available anymore but that there is are built in options to provide some of their functionality, like the light and dark theme in addition to the default theme and a way to change the interface density. And to mention that there are plenty of other themes available on AMO (with a link to https://addons.mozilla.org/firefox/themes/)

I would still like to see complete themes be moved to the legacy category, so that the themes category is cleaner for users, and so that we have less edge cases to care about in the themes(appearance) category in future updates, and have to just remove one category when removing all legacy for good.

With that combination we could have "Find Replacement" link for Complete Themes be routed to the SUMO page, as it would explain what users can replace their complete theme with. (if we do that via re-routing on AMO, or directly link to SUMO from Firefox doesn't matter to me... whatever is easier.)

(What I'd like to prevent is having a warning/error message above each complete theme.)

This solution possibly results in 2 notifications in Appearance ("Missing something?..." & "Looking to...") ... To prevent that clutter, I would like to only show "Missing something?..." if the user had a complete theme we disabled, with the option to dismiss this message. (Those messages look like something that could be aligned with the Message Bar UI we are currently defining: https://bwinton.github.io/photon/components/message-bars.html#generic adding Emanuala for that.)

Andrew, is that something you can work with, or do you need any more info from me?
Flags: needinfo?(emanuela)
Flags: needinfo?(aswan)
I put up a draft of the article here: https://support.mozilla.org/kb/built-themes-firefox-alternative-complete-themes

If you need an in-product link, please use this one: https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/complete-themes

If you have any suggestions, please need info me again or sign up for a SUMO account to edit the article directly (we will review it when you've submitted a change.)
Flags: needinfo?(jsavage)
Is the dismissable message bar something that already exists or just a design concept right now?
In any case, I'd feel a lot more comfortable about getting this done if we simplified it by removing the dismiss behavior.
Also, what should the text in the notification be?  Something like this?

Missing something? Some themes are no longer supported by &brandShortName;
Assignee: nobody → aswan
Flags: needinfo?(aswan) → needinfo?(mjaritz)
(In reply to Andrew Swan [:aswan] from comment #20)
> Is the dismissable message bar something that already exists or just a
> design concept right now?

Its first implementation will be around connecting your Firefox Account in Preferences. (I don't know if this landed.)


> In any case, I'd feel a lot more comfortable about getting this done if we
> simplified it by removing the dismiss behavior.

Then let's make you feel comfortable an not do the dismiss.


> Also, what should the text in the notification be?  Something like this?
> Missing something? Some themes are no longer supported by &brandShortName;

Yes, replacing extensions with themes should be enough. Thanks.
Flags: needinfo?(mjaritz)
Just to clarify, the current banner says:

Missing something?  Some extensions are no longer supported by Nightly.  Show legacy extensions.

where the second sentence is a link to the "Legacy Extensions" panel.  Putting together comment 2 and comment 21, it will now read:

Missing something?  Some themes are no longer supported by Nightly.  Show legacy extensions.

Correct?
Flags: needinfo?(mjaritz)
Comment on attachment 8907798 [details]
Bug 1384608 Show complete themes with legacy extensions

https://reviewboard.mozilla.org/r/179480/#review184814

::: toolkit/locales/en-US/chrome/mozapps/extensions/extensions.properties:194
(Diff revision 1)
>  type.service.name=Services
>  type.experiment.name=Experiments
>  type.legacy.name=Legacy Extensions
>  type.unsupported.name=Unsupported
> +
> +#LOCALIZATION NOTE(legacyWarning.description) %S is the localized brand name

localized brand -> brandShortName (also in the next comment)
(In reply to Andrew Swan [:aswan] from comment #22)
> Just to clarify, the current banner says:
> 
> Missing something?  Some extensions are no longer supported by Nightly. 
> Show legacy extensions.
> 
> where the second sentence is a link to the "Legacy Extensions" panel. 
> Putting together comment 2 and comment 21, it will now read:
> 
> Missing something?  Some themes are no longer supported by Nightly.  Show
> legacy extensions.
> 
> Correct?

Yes.
Flags: needinfo?(mjaritz)
Attachment #8907798 - Flags: review?(rhelmer)
Comment on attachment 8907798 [details]
Bug 1384608 Show complete themes with legacy extensions

https://reviewboard.mozilla.org/r/179480/#review185142
Attachment #8907798 - Flags: review?(rhelmer) → review+
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f2aa9d36be3f
Show complete themes with legacy extensions r=rhelmer
https://hg.mozilla.org/mozilla-central/rev/f2aa9d36be3f
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox57: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
I confirm that this issue is fixed on Firefox 57.0a1 (20170918220054) under Windows 10 64-bit and Mac OS X 10.12.3 and noticed the following:
  - complete themes are automatically disabled and displayed in Legacy Extensions tab
  - "Missing something? Some themes are no longer supported by Nightly. Show legacy extensions" banner is successfully displayed in “Themes” tab.
  - See screencast: https://drive.google.com/file/d/0B-KIyWoO4a-ldGt4cjNpVm9SVzQ/view?usp=sharing

Shouldn’t be there a space between Themes banners https://drive.google.com/file/d/0B-KIyWoO4a-lMG9MemZXeUVEWEU/view?usp=sharing ?
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
Flags: needinfo?(aswan)
(In reply to Vasilica Mihasca, QA [:vasilica_mihasca] from comment #31)
> Shouldn’t be there a space between Themes banners
> https://drive.google.com/file/d/0B-KIyWoO4a-lMG9MemZXeUVEWEU/
> view?usp=sharing ?

I don't know, the "spec" for this was comment 18, redirecting to Markus, though I understand he's off for another week or two so we won't get an answer right away...
Flags: needinfo?(aswan) → needinfo?(mjaritz)
Too late for 56. Mass won't fix for 56.
status-firefox56: affected → wontfix
(In reply to Andrew Swan [:aswan] from comment #32)
> (In reply to Vasilica Mihasca, QA [:vasilica_mihasca] from comment #31)
> > Shouldn’t be there a space between Themes banners
> > https://drive.google.com/file/d/0B-KIyWoO4a-lMG9MemZXeUVEWEU/
> > view?usp=sharing ?
> 
> I don't know, the "spec" for this was comment 18, redirecting to Markus,
> though I understand he's off for another week or two so we won't get an
> answer right away...

There should be only one message! The "complete themes" one, if it is needed.
Flags: needinfo?(mjaritz)
Flags: needinfo?(emanuela)
You need to log in before you can comment on or make changes to this bug.