1384709 - addEngineWithDetails should store the extension ID in the loadpath

Status: RESOLVED FIXED

(Firefox :: Search, enhancement)

Description

[Mike Kaply [:mkaply]]

Right now addEngineWithDetails uses

    engine._loadPath = "[other]addEngineWithDetails";

for the load path.

If there is an extensionID passed, we should incorporate it into the loadPath.

This was suggested on a patch in bug 1301315, but we ended up not modifying nsSearchServices, so it was lost.

From Florian:

> That being said, for loadpath, are you thinking:
> 
> if (aExtensionID) {
> engine._loadPath = "[" + aExtensionID + "]addEngineWithDetails";

I would prefer the string between [] to remain a constant, so I would like something like:
[extension]addEngineWithDetails:" + aExtensionID

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1384709 - Store extension ID in loadPath.

Review commit: https://reviewboard.mozilla.org/r/166194/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166194/

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8895064 [details]
Bug 1384709 - Store extension ID in loadPath.

https://reviewboard.mozilla.org/r/166194/#review172716

Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51ecd7a311ef
Store extension ID in loadPath. r=florian

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/51ecd7a311ef