fix pocket preffing causing non-local connection test failures

RESOLVED FIXED in Firefox 56

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 months ago

People

(Reporter: dmose, Assigned: dmose)

Tracking

unspecified
Firefox 56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Turning on pocket feeds by default in our github repo is causing our mochitests and talos tests on pine to fail.  We need to make sure this is fixed before we do our next export to mozilla-central.
Posted patch test-prefs-patch.diff (obsolete) — Splinter Review
This patch should staunch the bleeding.  I'm not sure it's the right fix for the slightly longer term (we probably want dummy data for the pocket feeds in the integration tests), but we need to staunch the bleeding ASAP so that we can land the latest activity-stream bits in mozilla-central to get them in nightly for telemetry and other reasons.

I'm working on testing this change locally and on pine to see if it fixes the problem.  Unfortunately, since artifact builds are busted, I've had to do a fresh debug build, which is taking a while...
This patch fixes talos and mochitests, but, oddly, not reftests.
Attachment #8890547 - Attachment is obsolete: true
Comment on attachment 8890560 [details]
Bug 1384721 - fix pocket network activity during tests,

https://reviewboard.mozilla.org/r/161704/#review167006
Attachment #8890560 - Flags: review?(edilee) → review+
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8798108d6ad4
fix pocket network activity during tests, r=Mardak
https://hg.mozilla.org/mozilla-central/rev/8798108d6ad4
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.