Closed Bug 1384721 Opened 5 years ago Closed 5 years ago

fix pocket preffing causing non-local connection test failures


(Firefox :: New Tab Page, enhancement)

Not set



Firefox 56
Tracking Status
firefox56 --- fixed


(Reporter: dmosedale, Assigned: dmosedale)




(1 file, 1 obsolete file)

Turning on pocket feeds by default in our github repo is causing our mochitests and talos tests on pine to fail.  We need to make sure this is fixed before we do our next export to mozilla-central.
Attached patch test-prefs-patch.diff (obsolete) — Splinter Review
This patch should staunch the bleeding.  I'm not sure it's the right fix for the slightly longer term (we probably want dummy data for the pocket feeds in the integration tests), but we need to staunch the bleeding ASAP so that we can land the latest activity-stream bits in mozilla-central to get them in nightly for telemetry and other reasons.

I'm working on testing this change locally and on pine to see if it fixes the problem.  Unfortunately, since artifact builds are busted, I've had to do a fresh debug build, which is taking a while...
This patch fixes talos and mochitests, but, oddly, not reftests.
Attachment #8890547 - Attachment is obsolete: true
Comment on attachment 8890560 [details]
Bug 1384721 - fix pocket network activity during tests,
Attachment #8890560 - Flags: review?(edilee) → review+
Pushed by
fix pocket network activity during tests, r=Mardak
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.