Cleanup toolchain job toolchain dependencies

RESOLVED FIXED in Firefox 56

Status

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla56

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(5 attachments)

Bug 1384417 through bug 1384422 merely converted the tooltool manifests to toolchain dependencies. But many of those dependencies are actually not used.

This is the cleanup for the toolchain jobs only (taskcluster/ci/toolchain/*).
Comment on attachment 8890622 [details]
Bug 1384744 - Allow toolchain tasks not to have a tooltool manifest at all.

https://reviewboard.mozilla.org/r/161744/#review167142
Attachment #8890622 - Flags: review?(gps) → review+
Comment on attachment 8890623 [details]
Bug 1384744 - Remove sccache dependencies for toolchain jobs.

https://reviewboard.mozilla.org/r/161746/#review167144
Attachment #8890623 - Flags: review?(gps) → review+
Comment on attachment 8890623 [details]
Bug 1384744 - Remove sccache dependencies for toolchain jobs.

https://reviewboard.mozilla.org/r/161746/#review167146

Although, when toolchains are themselves updated, it is not uncommon for multiple pushes to trigger the same TC task to build the toolchain. So sccache /could/ provide some benefit. But, yeah, since we're not using sccache today, removing it from the dependencies is correct.
Comment on attachment 8890624 [details]
Bug 1384744 - Remove unused toolchain dependencies for toolchain jobs.

https://reviewboard.mozilla.org/r/161748/#review167148
Attachment #8890624 - Flags: review?(gps) → review+
Comment on attachment 8890625 [details]
Bug 1384744 - Don't use tooltool manifests on toolchain jobs that don't need them.

https://reviewboard.mozilla.org/r/161750/#review167150
Attachment #8890625 - Flags: review?(gps) → review+
Comment on attachment 8890626 [details]
Bug 1384744 - Remove mozmake and rustc from the build-clang-cl tooltool manifest.

https://reviewboard.mozilla.org/r/161752/#review167152
Attachment #8890626 - Flags: review?(gps) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/7462800fd68e
Allow toolchain tasks not to have a tooltool manifest at all. r=gps
https://hg.mozilla.org/integration/autoland/rev/bb2e3d6da8fc
Remove sccache dependencies for toolchain jobs. r=gps
https://hg.mozilla.org/integration/autoland/rev/f95742f0fee9
Remove unused toolchain dependencies for toolchain jobs. r=gps
https://hg.mozilla.org/integration/autoland/rev/9484f5c0a7aa
Don't use tooltool manifests on toolchain jobs that don't need them. r=gps
https://hg.mozilla.org/integration/autoland/rev/d90974262a2c
Remove mozmake and rustc from the build-clang-cl tooltool manifest. r=gps
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.