Closed
Bug 1384749
Opened 8 years ago
Closed 8 years ago
Make Sentry use a more random identifier for device_app_hash
Categories
(Firefox for iOS :: General, enhancement)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | 8.1+ | --- |
People
(Reporter: st3fan, Assigned: st3fan)
Details
(Whiteboard: [Sentry])
Attachments
(1 file)
The default implementation of device_app_hash is a hash based on the IDFV plus additional properties of the device. We can change this to a (persisistent per install) random identifier that is not connected to iOS provided ID. This will then reset when the app is reinstalled.
|
Assignee | |
Updated•8 years ago
|
Whiteboard: [Sentry]
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → sarentz
|
|
Assignee | |
Comment 1•8 years ago
|
||
This patch changes the default `device_app_hash` implementation with our own. The Sentry implementation is based on the *Identifier For Vendors* while our implementation is simply a completely random identifier that is reset on every install.
|
|
Assignee | |
Updated•8 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8890863 [details] [review]
PR https://github.com/mozilla-mobile/firefox-ios/pull/2983
LGTM. See comment in PR about possibly using `NSUserDefaultsPrefs` instead.
Attachment #8890863 -
Flags: review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Landed on master, uplifted to v8.x
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•