Closed Bug 1384766 Opened 2 years ago Closed 2 years ago

Intermittent GeckoProfiler.SuspendAndSample | Value of: collector.mFrames > 5

Categories

(Core :: Gecko Profiler, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox56 --- fixed
firefox57 --- fixed

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed])

Some early failures were reported in bug 1358744.
It looks like this was introduced with bug 1380286.

:njn - Can you make this test more reliable?
Blocks: 1380286
Flags: needinfo?(n.nethercote)
Whiteboard: [stockwell needswork]
As njn pointed out, this is the same problem as Bug 1365309 comment 59, so this will probably go away when I land that.
Flags: needinfo?(n.nethercote)
(In reply to Michael Layzell [:mystor] from comment #5)
> As njn pointed out, this is the same problem as Bug 1365309 comment 59, so
> this will probably go away when I land that.

That landed 7 hours ago, so hopefully tomorrow's results will be much better for this test.
Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cecc62945523
Reduce expected frame count for GeckoProfiler.SuspendAndSample. r=njn.
(In reply to Nicholas Nethercote [:njn] from comment #9)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/
> cecc62945523b2ff6df76b8d3a7f8563de30fbcf
> Bug 1384766 - Reduce expected frame count for
> GeckoProfiler.SuspendAndSample. r=njn.

This was part 3 of bug 1365309. I landed it here to fix this intermittent failure now, so we don't have to wait for the problems in part 1 and/or part 2 to be debugged.
https://hg.mozilla.org/mozilla-central/rev/cecc62945523
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
https://hg.mozilla.org/releases/mozilla-beta/rev/d6f0fac3ee72
Whiteboard: [stockwell needswork] → [stockwell fixed]
You need to log in before you can comment on or make changes to this bug.