Closed Bug 1384779 Opened 2 years ago Closed 2 years ago

Intermittent browser/extensions/formautofill/test/browser/browser_autocomplete_marked_detached_tab.js | Uncaught exception - popup should be open - timed out after 50 tries.

Categories

(Toolkit :: Form Manager, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox56 --- fixed
firefox57 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: ralin)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:timing][form autofill:MVP])

Attachments

(1 file)

This new, frequent Windows intermittent suddenly stopped today...don't know why.
Whiteboard: [stockwell unknown]
No failures for a couple of days, but now they are quite frequent, on Windows 8/pgo and opt.

Overall, this test has been very unreliable since added in bug 1378754.

:mattn - Can you make this test more reliable?
Flags: needinfo?(MattN+bmo)
Whiteboard: [stockwell unknown] → [stockwell needswork]
Ray was making some changes to this test in another bug so I was hoping it may fix this…
(In reply to Matthew N. [:MattN] (huge backlog; PM if requests are blocking you) from comment #10)
> Ray was making some changes to this test in another bug so I was hoping it
> may fix this…

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac5dd1975a6ac07efcd3365e1b2470d496fcf394
It looks like the failure is still with my patch, marking this [form autofill:MVP].
Whiteboard: [stockwell needswork] → [stockwell needswork][form autofill:MVP]
Finally got the chance to test my patch...try server seems broken in the last few days. I have no idea why would be this case that only happens on Windows 8, perhaps, its native windows management is different from others. Anyway, taking this as I believe I've fixed the issue. See the try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9f7128d42d63508e8c7eca003fb35ce72ff1692
Assignee: nobody → ralin
Status: NEW → ASSIGNED
Comment on attachment 8897695 [details]
Bug 1384779 - Fix intermittent on browser_autocomplete_marked_detached_tab.js by ensuring popup closed before window detaching.

https://reviewboard.mozilla.org/r/168978/#review174322
Attachment #8897695 - Flags: review?(lchang) → review+
Thanks
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a917b05e1a23
Fix intermittent on browser_autocomplete_marked_detached_tab.js by ensuring popup closed before window detaching. r=lchang
Keywords: checkin-needed
Flags: needinfo?(MattN+bmo)
https://hg.mozilla.org/mozilla-central/rev/a917b05e1a23
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Looks like the problem is still, reopen the bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Hi gbrown,

I had a hard time finding a way to test "browser_autocomplete_marked_detached_tab.js" on try repo, but still have no clue why it only runs on other repos. Do you know how to trigger it on try? Thank you.
Flags: needinfo?(gbrown)
See Also: → 1391682
(In reply to Ray Lin[:ralin] from comment #24)
> I had a hard time finding a way to test
> "browser_autocomplete_marked_detached_tab.js" on try repo, but still have no
> clue why it only runs on other repos. Do you know how to trigger it on try?

It is tricky, because you have to explicitly request Windows 8 tests, and I don't think there is a way to do that with a path; I filed bug 1391682.

I think you have 2 options:

1. Run all the browser-chrome tests with:

./mach try -b do -p win64 -u mochitest-browser-chrome-e10s[Windows\ 8]

2. Manually create the proper try syntax for the path in your push. I did

hg qnew -e and added:

try: -b do -p win64 -u mochitest-browser-chrome-e10s-1[Windows 8] --try-test-paths browser-chrome:browser/extensions/formautofill/test/browser --artifact

then

hg push -f try

You can see that here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdfd2a36df00a7b1960443954d775425fa08a649
Flags: needinfo?(gbrown)
oddly there were failing on mozilla-inbound until the 18th, but now we have a couple days with no failures at all- we might be in the clear
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Whiteboard: [stockwell needswork][form autofill:MVP] → [stockwell fixed:timing][form autofill:MVP]
Comment on attachment 8897695 [details]
Bug 1384779 - Fix intermittent on browser_autocomplete_marked_detached_tab.js by ensuring popup closed before window detaching.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1378754
[User impact if declined]: None. This is an intermittent test failure.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes, intermittent is fixed.
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: No
[Is the change risky?]: No
[Why is the change risky/not risky?]: test-only change
[String changes made/needed]: None
Attachment #8897695 - Flags: approval-mozilla-beta?
Comment on attachment 8897695 [details]
Bug 1384779 - Fix intermittent on browser_autocomplete_marked_detached_tab.js by ensuring popup closed before window detaching.

This can land a=test-only.
Attachment #8897695 - Flags: approval-mozilla-beta?
You need to log in before you can comment on or make changes to this bug.