Closed
Bug 1384779
Opened 7 years ago
Closed 7 years ago
Intermittent browser/extensions/formautofill/test/browser/browser_autocomplete_marked_detached_tab.js | Uncaught exception - popup should be open - timed out after 50 tries.
Categories
(Toolkit :: Form Manager, defect, P5)
Toolkit
Form Manager
Tracking
()
RESOLVED
FIXED
mozilla57
People
(Reporter: intermittent-bug-filer, Assigned: ralin)
References
Details
(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:timing][form autofill:MVP])
Attachments
(1 file)
Filed by: wkocher [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=118104956&repo=mozilla-inbound https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win64-pgo/1501075805/mozilla-inbound_win8_64_test_pgo-mochitest-e10s-browser-chrome-3-bm119-tests1-windows-build86.txt.gz
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 3•7 years ago
|
||
This new, frequent Windows intermittent suddenly stopped today...don't know why.
Whiteboard: [stockwell unknown]
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 6•7 years ago
|
||
No failures for a couple of days, but now they are quite frequent, on Windows 8/pgo and opt. Overall, this test has been very unreliable since added in bug 1378754. :mattn - Can you make this test more reliable?
Flags: needinfo?(MattN+bmo)
Whiteboard: [stockwell unknown] → [stockwell needswork]
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 10•7 years ago
|
||
Ray was making some changes to this test in another bug so I was hoping it may fix this…
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 12•7 years ago
|
||
(In reply to Matthew N. [:MattN] (huge backlog; PM if requests are blocking you) from comment #10) > Ray was making some changes to this test in another bug so I was hoping it > may fix this… https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac5dd1975a6ac07efcd3365e1b2470d496fcf394 It looks like the failure is still with my patch, marking this [form autofill:MVP].
Whiteboard: [stockwell needswork] → [stockwell needswork][form autofill:MVP]
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 14•7 years ago
|
||
Finally got the chance to test my patch...try server seems broken in the last few days. I have no idea why would be this case that only happens on Windows 8, perhaps, its native windows management is different from others. Anyway, taking this as I believe I've fixed the issue. See the try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9f7128d42d63508e8c7eca003fb35ce72ff1692
Assignee: nobody → ralin
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 16•7 years ago
|
||
mozreview-review |
Comment on attachment 8897695 [details] Bug 1384779 - Fix intermittent on browser_autocomplete_marked_detached_tab.js by ensuring popup closed before window detaching. https://reviewboard.mozilla.org/r/168978/#review174322
Attachment #8897695 -
Flags: review?(lchang) → review+
Comment 18•7 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a917b05e1a23 Fix intermittent on browser_autocomplete_marked_detached_tab.js by ensuring popup closed before window detaching. r=lchang
Keywords: checkin-needed
Updated•7 years ago
|
Flags: needinfo?(MattN+bmo)
Comment 19•7 years ago
|
||
Thanks Ray!
Comment 20•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a917b05e1a23
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 23•7 years ago
|
||
Looks like the problem is still, reopen the bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 24•7 years ago
|
||
Hi gbrown, I had a hard time finding a way to test "browser_autocomplete_marked_detached_tab.js" on try repo, but still have no clue why it only runs on other repos. Do you know how to trigger it on try? Thank you.
Flags: needinfo?(gbrown)
Comment 25•7 years ago
|
||
(In reply to Ray Lin[:ralin] from comment #24) > I had a hard time finding a way to test > "browser_autocomplete_marked_detached_tab.js" on try repo, but still have no > clue why it only runs on other repos. Do you know how to trigger it on try? It is tricky, because you have to explicitly request Windows 8 tests, and I don't think there is a way to do that with a path; I filed bug 1391682. I think you have 2 options: 1. Run all the browser-chrome tests with: ./mach try -b do -p win64 -u mochitest-browser-chrome-e10s[Windows\ 8] 2. Manually create the proper try syntax for the path in your push. I did hg qnew -e and added: try: -b do -p win64 -u mochitest-browser-chrome-e10s-1[Windows 8] --try-test-paths browser-chrome:browser/extensions/formautofill/test/browser --artifact then hg push -f try You can see that here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdfd2a36df00a7b1960443954d775425fa08a649
Flags: needinfo?(gbrown)
Comment hidden (Intermittent Failures Robot) |
Comment 27•7 years ago
|
||
oddly there were failing on mozilla-inbound until the 18th, but now we have a couple days with no failures at all- we might be in the clear
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
Whiteboard: [stockwell needswork][form autofill:MVP] → [stockwell fixed:timing][form autofill:MVP]
Updated•7 years ago
|
status-firefox56:
--- → affected
Comment 28•7 years ago
|
||
Comment on attachment 8897695 [details] Bug 1384779 - Fix intermittent on browser_autocomplete_marked_detached_tab.js by ensuring popup closed before window detaching. Approval Request Comment [Feature/Bug causing the regression]: bug 1378754 [User impact if declined]: None. This is an intermittent test failure. [Is this code covered by automated tests?]: Yes [Has the fix been verified in Nightly?]: Yes, intermittent is fixed. [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: No [Is the change risky?]: No [Why is the change risky/not risky?]: test-only change [String changes made/needed]: None
Attachment #8897695 -
Flags: approval-mozilla-beta?
Comment 29•7 years ago
|
||
Comment on attachment 8897695 [details] Bug 1384779 - Fix intermittent on browser_autocomplete_marked_detached_tab.js by ensuring popup closed before window detaching. This can land a=test-only.
Attachment #8897695 -
Flags: approval-mozilla-beta?
Comment 30•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/c825b305f34f
Flags: in-testsuite+
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•