Closed Bug 1384812 Opened 6 years ago Closed 6 years ago

The Learn more link of the automaticallySubmitCrashesBox checkbox should not align right side and the defaultEngineGroup checkbox should not be full width after Bug 1382660 is landed.

Categories

(Firefox :: Settings UI, defect, P1)

Product:
Firefox
Component:
Settings UI
Version:
55 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 56
Tracking Flags:
Tracking Status
firefox56 --- verified

People

(Reporter: evanxd, Assigned: evanxd)

References

Details

(Whiteboard: [photon-preference])

Attachments

(5 files)

screenshot.png
427.20 KB, image/png
Details
Bug 1384812 - Remove the flex=1 attribute from submitHealthReportBox and automaticallySubmitCrashesBox checkboxes because they have learn-more links in the same line which should appear next to the checkbox instead of at the end of the line.
59 bytes, text/x-review-board-request
jaws
: review+
Details
correct-result.png
386.62 KB, image/png
Details
Bug 1384812 - Add hbox for the defaultEngine menulist because we would like to make the menulist width just align its content width.
59 bytes, text/x-review-board-request
jaws
: review+
Details
screenshot-for-search-pane.png
322.42 KB, image/png
Details
Attached image screenshot.png — 
The Learn more link of  the automaticallySubmitCrashesBox checkbox should not align right side.
Flags: qe-verify+
Attachment #8890676 - Flags: review?(jaws)
Hi Jared, 

Could you help review the patch?

Thank you.
Attached image correct-result.png — 
After removing the flex=1, it make thing correct. See it in the attachment.
Attachment #8890782 - Flags: review?(jaws)
Summary: The Learn more link of the automaticallySubmitCrashesBox checkbox should not align right side. → The Learn more link of the automaticallySubmitCrashesBox checkbox should not align right side and the defaultEngineGroup checkbox should not be full width after Bug 1382660 is landed.
The defaultEngine menulist should not be full width.
Comment on attachment 8890676 [details]
Bug 1384812 - Remove the flex=1 attribute from submitHealthReportBox and automaticallySubmitCrashesBox checkboxes because they have learn-more links in the same line which should appear next to the checkbox instead of at the end of the line.

https://reviewboard.mozilla.org/r/161854/#review167580

::: commit-message-f1693:1
(Diff revision 1)
> +Bug 1384812 - Remove the flex=1 attribute from submitHealthReportBox and automaticallySubmitCrashesBox checkboxes.

This commit message should say "why" it is doing something, not just "what" it is doing.

Please add in here that these checkboxes should not have flex=1 because they have learn-more links in the same line which should appear next to the checkbox instead of at the end of the line.
Attachment #8890676 - Flags: review?(jaws) → review+
Comment on attachment 8890782 [details]
Bug 1384812 - Add hbox for the defaultEngine menulist because we would like to make the menulist width just align its content width.

https://reviewboard.mozilla.org/r/161976/#review167582

::: commit-message-8f0d3:1
(Diff revision 1)
> +Bug 1384812 - Add start align box for the defaultEngine menulist.

This commit message also needs to be improved.

Please explain why in the commit message that this should be done.
Attachment #8890782 - Flags: review?(jaws) → review+
Comment on attachment 8890782 [details]
Bug 1384812 - Add hbox for the defaultEngine menulist because we would like to make the menulist width just align its content width.

https://reviewboard.mozilla.org/r/161976/#review167582

> This commit message also needs to be improved.
> 
> Please explain why in the commit message that this should be done.

Sure, let's do it. And I'll do that way in the future.
Thank you for reviewing the patch, Jared. Let's land it once the try[1] is good.

[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=94818e0039d3
The try is good. Let's land it.
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4283d0e4b1d6
Remove the flex=1 attribute from submitHealthReportBox and automaticallySubmitCrashesBox checkboxes because they have learn-more links in the same line which should appear next to the checkbox instead of at the end of the line. r=jaws
https://hg.mozilla.org/integration/autoland/rev/fda73b7884df
Add hbox for the defaultEngine menulist because we would like to make the menulist width just align its content width. r=jaws
Keywords: checkin-needed
Build ID: 20170730100307
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

Verified as fixed on Firefox Nightly 56.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
status-firefox56: fixed → verified
You need to log in before you can comment on or make changes to this bug.