1384828 - MOZ_RELEASE_ASSERT(isOnUiThread) crash for CreateCompositor

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

This bug was filed from the Socorro interface and is 
report bp-6a9f0bf1-8ad4-49db-9375-4b66e0170727.
=============================================================

I think the CreateCompositor call is being executed before we've had a chance to register the UI thread in Gecko, so Gecko thinks we're not on the UI thread.

Comment 1

[Calixte Denizet (:calixte)]

This signature is ranked #3 in top-crashers.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Use tid for UI thread detection (v1)

Use the UI thread's tid for checking if we're on the UI thread in Gecko.
This lets us get rid of `GeckoThread.registerUiThread`, in order to
avoid a race where we check for UI thread before `registerUiThread` is
called.

Comment 3

[Eugen Sawin [:esawin]]

Comment on attachment 8892200 [details] [diff] [review]
Use tid for UI thread detection (v1)

Review of attachment 8892200 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoThread.java
@@ +109,5 @@
>      private static final ClassLoader clsLoader = GeckoThread.class.getClassLoader();
>      @WrapForJNI
>      private static MessageQueue msgQueue;
> +    @WrapForJNI
> +    private static int uiThreadTid;

I think it should be uiThreadId, the T is redundant (throughout the patch).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ddc27194c0e
Use tid for UI thread detection; r=esawin

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2ddc27194c0e

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Attachment to Bug 1384828 - MOZ_RELEASE_ASSERT(isOnUiThread) crash for CreateCompositor

Use tid for UI thread detection (v1.1)

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

I just remembered this crash is a diagnostic crash that only affects Nightly and shouldn't have any negative impact on Beta, so it's okay to wontfix on 56 and not uplift the patch.

Comment 9

[Aki Sasaki (not active)]

https://hg.mozilla.org/projects/date/rev/2ddc27194c0eaa302a394ab38eea07936cec837b
Bug 1384828 - Use tid for UI thread detection; r=esawin