1384843 - Respect Telemetry opt-out and don't collect metrics

Status: RESOLVED FIXED

(Snippets :: Service, enhancement)

Description

[Giorgos Logiotatidis [:giorgos]]

If users have opt-ed out form Telemetry we should not collect any metrics. Target for this is Activity Stream which will gradually take over about:home and about:newtab

Comment 1

[Giorgos Logiotatidis [:giorgos]]

Benjamin,

we want to collect snippet metrics (impressions, clicks, etc) in Activity Stream only for users who have opted in Telemetry.

Can you please advise which pref is the right one to monitor to check if users opted-in Telemetry?

Is it  

 - datareporting.healthreport.uploadEnabled
 - datareporting.policy.dataSubmissionEnabled

or another one?

Thanks

Comment 2

[Benjamin Smedberg]

Whatever the checkbox in prefs toggles, but I don't remember the technical details -> gfritzsche

Related, I just want to clarify terminology: this checkbox is *opt-out* (default-on), not opt-in.

Comment 3

[Georg Fritzsche [:gfritzsche]]

I'm not sure what exact setting you are looking for.
Are you looking to collect the metrics for all users that did not opt out?

Please don't use the prefs directly, instead use:
- for "is opt-out data enabled?": Services.telemetry.canRecordBase
- for "is opt-in data enabled?": Services.telemetry.canRecordExtended

Comment 4

[Giorgos Logiotatidis [:giorgos]]

OK We'll use Services.telemetry.canRecordBase and only collect metrics if that's set to True.

Comment 5

[Kate Hudson :k88hudson]

Is there a way to observe changes in Services.telemetry.canRecordBase?

Comment 6

[Georg Fritzsche [:gfritzsche]]

Not currently. We can add it though, you could file a bug for it in Toolkit::Telemetry.

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozmeao/snippets-service

https://github.com/mozmeao/snippets-service/commit/95b04094463b42995389a8ef8ad5be077eae8001
[fix bug 1384843] Don't collect metrics if user have opted out from telemetry.

See also https://github.com/mozilla/activity-stream/commit/aeee212d3f0c4ede4647e065af8a328ca6f5bc11

https://github.com/mozmeao/snippets-service/commit/94556703e0c24c21171150c4ecb73cd143c7270e
Merge pull request #262 from glogiotatidis/telemetryEnalbed

[fix bug 1384843] Don't collect metrics if user have opted out from telemetry