Closed
Bug 1384848
Opened 7 years ago
Closed 7 years ago
Remove dead code in XPCConvert.cpp
Categories
(Core :: XPConnect, enhancement)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: [CID 1274675])
Attachments
(1 file)
if (0 != count), we already exited the function if (0 != count) { if (pErr) *pErr = NS_ERROR_XPC_NOT_ENOUGH_CHARS_IN_STRING; return false; } The rest is dead code
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → sledru
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8890738 [details] Bug 1384848 - Remove dead code in XPCConvert.cpp https://reviewboard.mozilla.org/r/161938/#review167292 Not super-familiar with this code. It looks like the code was inadvertently made dead in bug 677788. I would r+, but maybe there's a secret bug lurking in here somewhere? OTOH, given that we've had this behavior for six years, maybe nothing really relies on it? I'd feel a little better if somebody who knew things about xpconnect gave this a once-over; I'll redirect the review. ::: js/xpconnect/src/XPCConvert.cpp:1757 (Diff revision 1) > if (0 != count) { > len = (count + 1) * sizeof(char16_t); > if (!(*((void**)d) = moz_xmalloc(len))) > return false; > return true; > } > This code is also likewise dead, isn't it?
Comment 3•7 years ago
|
||
Comment on attachment 8890738 [details] Bug 1384848 - Remove dead code in XPCConvert.cpp Blake reviewed bug 677788, so maybe he knows something about this code?
Attachment #8890738 -
Flags: review?(nfroyd) → review?(mrbkap)
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8890738 [details] Bug 1384848 - Remove dead code in XPCConvert.cpp https://reviewboard.mozilla.org/r/161938/#review167542 This looks right to me.
Attachment #8890738 -
Flags: review?(mrbkap) → review+
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8816877de730 Remove dead code in XPCConvert.cpp r=mrbkap
Assignee | ||
Comment 7•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/816e61957699d19eb96dfccd014ca0487337f065 Bug 1384848 - Remove dead code in XPCConvert.cpp r=mrbkap
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8816877de730
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/816e61957699
You need to log in
before you can comment on or make changes to this bug.
Description
•