1384860 - No focus on URL bar when Welcome screen is dismissed

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Awesomescreen, defect, P5)

Description

[Sorina Florean [:sflorean]]

Environment: 
Device: Motorola Nexus 6 (Android 7.0);
Build: Nightly 56.0a1 (2017-07-26);

Steps to reproduce:
1. Launch Fennec with a clean profile;
2. Swipe the content for the slides;
3. On the last panel tap on "Not right now".

Expected result:
Welcome screen is dismissed; about:home is displayed with focus on the URL bar.

Actual result:	
Welcome screen is dismissed; about:home is displayed with NO focus on the URL bar, and also keyboard is not displayed.

Comment 1

[Max Liu [:maliu]]

(In reply to Sorina Florean [:sorina] from comment #0)
> Expected result:
> Welcome screen is dismissed; about:home is displayed with focus on the URL
> bar.

Hi Sorina,

I wonder why would we expect the focus is on URL bar. Because whenever a new tab is created, we did not focus on URL bar. Also, if we focus on URL bar, the menu button is hidden, would it be expected when user dismiss Welcome screen and couldn't see the menu button?

We probably need UX input, what do you think :jalin?

Comment 2

[Sorina Florean [:sflorean]]

When we are on the last slide from the Welcome screen the user has two options: "Sign in to sync" or "Not right now". So if the user don't want to log in with a Firefox account maybe that he/she wants to search for something? This behavior was implemented before, this is a regression. 
If is needed I can investigate more and search for a regression window. We can wait for :jalin response. Thanks!

Comment 3

[Nevin Chen(Not active on Bugzilla)]

To me it's like P3. Feel free to change it back

Comment 4

[Andrew Overholt [:overholt]]

(In reply to Nevin Chen [:nechen] from comment #3)
> To me it's like P3. Feel free to change it back

Given this and the delay hearing back from UX, let's say we're not going to fix this in 58 or 59.

Comment 5

[Pascal Chevrel:pascalc]

AFAIK, Jalin no longer works on Firefox for Android so removing the needinfo request.
Marking as fix-optional for 63

Comment 6

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 7

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Marking fix-optional for 64. We could still take a patch in 65.

Comment 8

[Pascal Chevrel:pascalc]

Updating tracking flags as we get closer to the 64 release.

Comment 9

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Since this is P5 and a longstanding issue we don't need to keep setting the flags here.
I'll remove the regression flag here and mark it as a good first bug.

Comment 10

[dmaciel10123]

Since this is listed as a good first bug and doesn't appear to be high importance, I'll work on taking care of this.

Based on the comments above, the idea is to focus on the address bar if the user declines to sign in and sync accounts. Please correct me if this isn't the case.

Comment 11

[swaroop.rao]

I can work on this if somebody is willing to mentor me. I've submitted a couple of bug fixes before and I've got the codebase ready to go.

Comment 12

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.