Closed Bug 1384871 Opened 2 years ago Closed Last year

Port Bug 1369801 - Ship DevTools as a system-addon to C-C

Categories

(Thunderbird :: General, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: jorgk-bmo, Unassigned)

Details

Attachments

(3 files, 2 obsolete files)

No description provided.
Missed some.
Attachment #8890777 - Attachment is obsolete: true
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/27ed1d75dcda
Port Bug 1369801 to C-C [Ship DevTools as a system-addon]. rs=bustage-fix
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 56.0
Attached file xpcshell-failures.txt
With the patch in place, we had a lot of Xpcshell test failures, see attachment.

In a local build, starting the Error Console gives:
[5204] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111: file c:/mozilla-source/comm-central/mozilla/startupcache/StartupCacheUtils.cpp, line 173
[5204] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111: file c:/mozilla-source/comm-central/mozilla/js/xpconnect/loader/mozJSComponentLoader.cpp, line 921
JavaScript error: chrome://messenger/content/mailWindowOverlay.js, line 20: NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIXPCComponents_Utils.import]

M-C backed out bug 1369801, so I'll do the same here.

However, we should get ready for next time. Philipp, can you please take a look at what needs to be done here.
Flags: needinfo?(philipp)
I think we might need to add an entry for the Thunderbird application ID (3550f703-e582-4d05-9a08-453d09bdfdc6) in devtools' install.rdf.

For reference this is what the install.rdf looked like when it landed on central previously: https://hg.mozilla.org/mozilla-central/raw-file/ad2610a5e6ba/devtools/install.rdf
Can you please do that. And while you're at it, please as SeaMonkey as well.

TB versions and FF versions are the same, but SM have their own (crazy) numbering scheme: SM = 2.0 + FF/100 - 0.03.

Assuming you're going with 44.0 (why?), you'd get: 2.0 + 0.44 - 0.03 = 2.41.

  <em:targetApplication>
    <Description>
    <!-- Thunderbird -->
    <em:id>{3550f703-e582-4d05-9a08-453d09bdfdc6}</em:id>
    <em:minVersion>44.0a1</em:minVersion>
    <em:maxVersion>*</em:maxVersion>
    </Description>
  </em:targetApplication>

  <em:targetApplication>
    <Description>
    <!-- SeaMonkey -->
    <em:id>{92650c4d-4b8e-4d2a-b7eb-24ecf4f6b63a}</em:id>
    <em:minVersion>2.41a1</em:minVersion>
    <em:maxVersion>*</em:maxVersion>
    </Description>
  </em:targetApplication>

Thanks a lot in advance.

FRG, can you please confirm the SM numbering scheme.
Flags: needinfo?(frgrahl)
Would it be sufficient to add the toolkit em:id instead?
Flags: needinfo?(philipp) → needinfo?(jdescottes)
OK, I guess Instantbird also needs to be added, Patrick?
Attached file install.rdf (obsolete) —
I've added the comm-central applications to the install.rdf file.

Julian, would it be possible to add it like this in
Attachment #8892396 - Flags: feedback?(jdescottes)
Attachment #8892396 - Attachment mime type: application/rdf+xml → text/plain
Richard, wrong version for SM, needs to be 2.41 as per comment #7. Also attach file as text/plain, please.
(In reply to Jorg K (GMT+2) from comment #7)
> 
> Assuming you're going with 44.0 (why?), 
> 

For the DevTools system-addon, the version is not really relevant as we don't plan to publish any update to it. It just needs to be compatible with any possible version. When we move to updating the addon we'll reconsider this.

44.0 just happened to be the current Firefox version when we started experimenting with DevTools as an addon in 2016.
Flags: needinfo?(jdescottes)
SeaMonkey for historical reasons uses the Gecko version - 3 so Fx 56 / Gecko 56 (current mozilla-central) is 2.53.

We already debated to change this in a future release. Probably when the classic extensions are gone.

I am quite sure this will still fail for both TB and SM because devtools is very tightly integrated into the Firefox menu and modules structure but we will see.
Flags: needinfo?(frgrahl)
Attached file install.rdf
Updated the SM version (2.41a1) to the correlating Gecko version (44.0a1)
Attachment #8892396 - Attachment is obsolete: true
Attachment #8892396 - Flags: feedback?(jdescottes)
Attachment #8892399 - Flags: feedback?(jdescottes)
Attachment #8892399 - Attachment mime type: application/rdf+xml → text/plain
Comment on attachment 8892399 [details]
install.rdf

Thanks for the patch, but for now we will go with the approach used in https://bugzilla.mozilla.org/show_bug.cgi?id=1388412

It uses the toolkit id rather than having a specific entry for each application. I hope this can work fine for all the applications listed here.
Attachment #8892399 - Flags: feedback?(jdescottes)
Assignee: jorgk → nobody
Whiteboard: [patchlove]
Target Milestone: Thunderbird 56.0 → ---
But 1369801 never went ahead, so there's nothing to port/fix here.
Status: REOPENED → RESOLVED
Closed: 2 years agoLast year
Resolution: --- → WONTFIX
Whiteboard: [patchlove]
You need to log in before you can comment on or make changes to this bug.