I encountered build fail after pull the latest code. Here is the error message. 0:33.26 In file included from /Users/jybowser/git/gecko/obj-x86_64-apple-darwin15.6.0/media/webrtc/trunk/webrtc/modules/modules_desktop_capture/Unified_mm_webrtc_modules0.mm:38: 0:33.26 /Users/jybowser/git/gecko/media/webrtc/trunk/webrtc/modules/desktop_capture/screen_capturer_mac.mm:429:33: error: unknown type name 'ScreenCallbackData' 0:33.26 : screen_callback_data_(new ScreenCallbackData(this)) 0:33.26 ^ 0:33.30 /Users/jybowser/git/gecko/media/webrtc/trunk/webrtc/modules/desktop_capture/screen_capturer_mac.mm:440:26: error: use of undeclared identifier 'screen_callback_data_' 0:33.30 rtc::CritScope lock(&screen_callback_data_->crit_sect_); 0:33.30 ^ 0:33.35 /Users/jybowser/git/gecko/media/webrtc/trunk/webrtc/modules/desktop_capture/screen_capturer_mac.mm:441:5: error: use of undeclared identifier 'screen_callback_data_' 0:33.35 screen_callback_data_->capturer = nullptr; 0:33.35 ^ 0:33.50 3 errors generated. 0:33.52 make: *** [Unified_mm_webrtc_modules0.o] Error 1 0:33.52 make: *** [media/webrtc/trunk/webrtc/modules/modules_desktop_capture/target] Error 2 0:33.52 make: *** Waiting for unfinished jobs.... 0:33.70 libfreebl3.dylib It is introduced by this changeset. https://hg.mozilla.org/mozilla-central/rev/baa75a499752 The patch in the attachment can fix the build fail, but I am not sure whether it is a correct fix or not since I cannot access to this Bug 1368030
+1 I am seeing this issue as well.
Why didn't this break on try?
The changeset add codes inside some version-dependent #ifdefs, so this build fail only present under newer OSX I think. Our tryserver does not have latest OSX for testing, so this failure is not covered in tests.
The patch in the attachment can be a temporary workaround for the build fail. Maybe you can try it until the owner of Bug 1368030 fix this issue.
This moves the added structure inside an #else in the #ifdef. Please test locally, I have no way of verifying if this fixes your build issue :)
Assignee: nobody → dminor
Status: NEW → ASSIGNED
Attachment #8890914 - Flags: review?(mfroman)
I verified it fixes the build on both 10.11 and 10.12.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/c1aab6bb5ab4 Fix build failure on OSX 10.11.6 after Bug 1368030 landed; r=mjf
This fix for this was included in the uplift patches of bug 1368030, so calling other branches unaffected.
You need to log in before you can comment on or make changes to this bug.