Closed Bug 1384891 Opened 8 years ago Closed 8 years ago

Undefined instead of menu items

Categories

(developer.mozilla.org Graveyard :: KumaScript, enhancement)

Product:
developer.mozilla.org Graveyard
Component:
KumaScript
Platform:
All
Other
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: looct12, Unassigned)

Details

(Whiteboard: [specification][type:bug])

What did you do? ================ 1. Open the link https://developer.mozilla.org/ru/docs/Web/HTTP/Methods (in rus localization)   What happened? ============== https://www.dropbox.com/s/hcy4ol4pincp6g4/2017072724.png?dl=0 Undefined instead of menu items What should have happened? ========================== Correct names of menu items Is there anything else we should know? ======================================
looks like it's because of that properties are only partially defined in https://github.com/mozilla/kumascript/blob/master/macros/HTTPSidebar.ejs fscholz, does "mdn.localString" support fallback for nested objects?
Flags: needinfo?(fscholz)
if the following is the actual implementation (not sure), it doesn't fallback to en-US for nested case. https://github.com/mozilla/kumascript/blob/0832f5c9b8550f71f17f5a882cc80b14f921a336/macros/MDN-Common.ejs#L33-L37
Component: Wiki pages → KumaScript
Status: UNCONFIRMED → NEW
Ever confirmed: true
(In reply to Tooru Fujisawa [:arai] from comment #1) > looks like it's because of that properties are only partially defined in > https://github.com/mozilla/kumascript/blob/master/macros/HTTPSidebar.ejs > > fscholz, does "mdn.localString" support fallback for nested objects? Unfortunately not :( I think the real fix will be bug 1378386 which should make all this a lot cleaner. In meantime we could just define everything for "ru" (using the English strings). The implementation of this sidebar will probably be changed once bug 1378386 is landed.
Flags: needinfo?(fscholz)
as an interim fix, added mdn.localStringMap that does fallback for each object property. https://github.com/mozilla/kumascript/pull/261
Commits pushed to master at https://github.com/mozilla/kumascript https://github.com/mozilla/kumascript/commit/9686490bf859a673eb6adb29b7f1a6f2c2dda194 Bug 1384891 - Add mdn.localStringMap and use it where localizing multiple texts. https://github.com/mozilla/kumascript/commit/b2ee662022053d4990b23b06df364f94a6b6c485 Merge pull request #261 from arai-a/localStringMap Bug 1384891 - Add mdn.localStringMap and use it where localizing multiple texts.
The fix has been pushed to prod. I refreshed the Russian page in question here. Thanks again, arai!
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Commits pushed to topicbox-de-translation at https://github.com/mdn/kumascript https://github.com/mdn/kumascript/commit/9686490bf859a673eb6adb29b7f1a6f2c2dda194 Bug 1384891 - Add mdn.localStringMap and use it where localizing multiple texts. https://github.com/mdn/kumascript/commit/b2ee662022053d4990b23b06df364f94a6b6c485 Merge pull request #261 from arai-a/localStringMap
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.