1384938 - funsize groups show "unknown" in tooltip

Status: VERIFIED FIXED

(Release Engineering :: Release Automation: Other, enhancement)

Description

[[e-mail] (:bhearsum)]

Eg: the "fs-g-1" group on https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=e5693cea1ec944ca077c7a46c5f127c828a90f1b. Hard to decode unless you already know what funsize is.

Comment 1

[Jonathan French (:jfrench)]

For what its worth it appears 'groupName' and 'tier' are missing from the TC Treeherder json in funsize jobs.
https://tools.taskcluster.net/groups/Cr8c0VCdSTWcPh6F_ico5A/tasks/eaUaSOyYS8muPZ5A2_0x4Q/details

Comment 2

[Jonathan French (:jfrench)]

I've opened a PR in the Funsize repo for this. I assume this bug should be moved over there, but I've noted it here.
https://github.com/mozilla-releng/funsize/pull/80

Comment 3

[Jonathan French (:jfrench)]

Attachment: PR 80

Comment 4

[Jonathan French (:jfrench)]

I took a flier on the Product/Component reassignment, from Treeherder to Releng based on other bugs I looked at. If I'm wrong, apologies :)

Comment 5

[Jonathan French (:jfrench)]

Comment on attachment 8893116 [details] [review]
PR 80

Adding catlee for review at your leisure. Feel free to reassign if needed :)

Comment 6

[Chris AtLee [:catlee]]

Comment on attachment 8893116 [details] [review]
PR 80

LGTM, but I'll let the funsize expert weigh in.

Comment 7

[Simon Fraser [:sfraser] ⌚️GMT]

Looks good to me. groupName for the signing and update tasks would complete the set.

Comment 8

[Jonathan French (:jfrench)]

Thanks Simon let me know if there's anything to be done on my end. :) It appears it can be merged based on those additions.

Comment 9

[Jonathan French (:jfrench)]

I've confirmed the task definitions are updating correctly with these new properties. :bearsum this fix should be present and visible in Treeherder after bug 1215587 is fixed and merged, which :camd mentioned should be in a week or two.

Comment 10

[Jonathan French (:jfrench)]

Verified fixed on production in central.