1384971 - History UI slide animation got worse?

Status: RESOLVED WORKSFORME

(Firefox :: Toolbars and Customization, defect)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

Click on Library, then History.  The animation for the sliding in got worse, either with 20170727100347 or a day or two preceding it.

It is particularly noticeable if you customize the toolbar with a direct link to history.  At least for me.

If you look at the first animation in this recording, it's good:
https://www.youtube.com/watch?v=ZnNQFe1L8Hc

If you look at the last one, you can see where the weird thing happens:
https://www.youtube.com/watch?v=ZnNQFe1L8Hc&t=75

Comment 1

[:Gijs (he/him)]

Can you find a regression window? Because on the frontend side, the only relevant bug is bug 1354533 (which landed in yesterday's nightly), but so far most of the issues I've seen filed in the last few days have been related to gecko issues (cf. bug 1382918). If you can easily verify good/bad behaviour on your machine, narrowing down a regressor would really help getting this addressed.

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

I have very little confidence in this regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0faada5c2f308f101ab7c54a87b3dce80b97d0e3&tochange=7ce557b85b611536b69539a7c18d4834ffc92eea

Comment 3

[:Gijs (he/him)]

(In reply to Milan Sreckovic [:milan] from comment #2)
> I have very little confidence in this regression range:
> https://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=0faada5c2f308f101ab7c54a87b3dce80b97d0e3&tochange=7ce5
> 57b85b611536b69539a7c18d4834ffc92eea

OK, but that's significantly longer ago than the last few days. Does that seem right?

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Yes, it seems to be longer than that.  Pre bug 1354533 we had a slightly different behaviour, sometimes I don't get anything in that menu, but I think the "make it full size, then go back and animate the transition" was there before that patch as well.
I'll check tomorrow given bug 1382918 comment 17, it may very well be a duplicate of that.

Comment 5

[:Gijs (he/him)]

Given both bug 1382627 and bug 1382918 have been marked wfm/fixed, I just want to check, is this better now, too?

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

Not any better in 20170730100307, but I can check tomorrow as well.

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

Seems to be OK in 20170912100139.  Closing.  If it comes back, I can bisect for what fixed it.