Remove the height transition from the pseudo class panel

RESOLVED FIXED in Firefox 56

Status

enhancement
P3
normal
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: gl, Assigned: gl)

Tracking

unspecified
Firefox 56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(2 attachments)

Posted image Artifact
We have an artifact where you can see the input boxes of the pseudoclasses when toggling show/hide of the pseudoclass panel. See Artifact screenshot.

This could be fixed by adding a -1 z-index to http://searchfox.org/mozilla-central/source/devtools/client/themes/rules.css#62, but since we don't have any transition for the class panel as well, and would be a bit difficult to add it given the current DOM structure. I think it would be wise to remove the transition for now. Also, height cannot be animated cheaply by the browsers compare to translate, scale, rotate and opacity. https://www.html5rocks.com/en/tutorials/speed/high-performance-animations/
Posted patch 1384976.patchSplinter Review
Attachment #8890926 - Flags: review?(jdescottes)
Attachment #8890926 - Flags: review?(jdescottes) → review?(tigleym)
Attachment #8890926 - Flags: review?(tigleym)
Attachment #8890926 - Flags: review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/57ff68e8e3fc
Remove the height transition from the pseudo class panel. r=micah
The last merge to MC didn't mark the bugs as fixed!
Flags: needinfo?(aryx.bugmail)
Yes, that's blocked by bug 1385682.
Flags: needinfo?(aryx.bugmail)
https://hg.mozilla.org/mozilla-central/rev/57ff68e8e3fc
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.