Closed
Bug 1384976
Opened 7 years ago
Closed 7 years ago
Remove the height transition from the pseudo class panel
Categories
(DevTools :: Inspector: Rules, enhancement, P3)
DevTools
Inspector: Rules
Tracking
(firefox56 fixed)
RESOLVED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: gl, Assigned: gl)
Details
Attachments
(2 files)
We have an artifact where you can see the input boxes of the pseudoclasses when toggling show/hide of the pseudoclass panel. See Artifact screenshot. This could be fixed by adding a -1 z-index to http://searchfox.org/mozilla-central/source/devtools/client/themes/rules.css#62, but since we don't have any transition for the class panel as well, and would be a bit difficult to add it given the current DOM structure. I think it would be wise to remove the transition for now. Also, height cannot be animated cheaply by the browsers compare to translate, scale, rotate and opacity. https://www.html5rocks.com/en/tutorials/speed/high-performance-animations/
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8890926 -
Flags: review?(jdescottes)
Assignee | ||
Updated•7 years ago
|
Attachment #8890926 -
Flags: review?(jdescottes) → review?(tigleym)
Updated•7 years ago
|
Attachment #8890926 -
Flags: review?(tigleym)
Attachment #8890926 -
Flags: review+
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/57ff68e8e3fc Remove the height transition from the pseudo class panel. r=micah
Comment 3•7 years ago
|
||
The last merge to MC didn't mark the bugs as fixed!
Flags: needinfo?(aryx.bugmail)
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/57ff68e8e3fc
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•